Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: helloMMS Converge on one Dockerfile #564

Closed
johnwalicki opened this issue Oct 31, 2022 · 4 comments · Fixed by #574
Closed

Feature Request: helloMMS Converge on one Dockerfile #564

johnwalicki opened this issue Oct 31, 2022 · 4 comments · Fixed by #574
Assignees

Comments

@johnwalicki
Copy link
Member

johnwalicki commented Oct 31, 2022

Is your feature request related to a problem? Please describe.

Using the technique described in #560 and implemented in #561
The same can be done for helloMMS

Many of the examples/ repos have Dockerfile.amd64 / Dockerfile.arm / Dockerfile.arm64 / Dockerfile.ppc64le
I did a meld on some of these Dockerfiles and they are slightly different. (which is not good)
These multiple Dockerfiles and differences are unnecessary. We could delete them all. Create one common Dockerfile

Then in the Makefile, tell the docker build --platform linux/$(ARCH)
Docker/Podman will figure out which arch image to pull and build.

Describe the solution you'd like.

Remove all the Dockerfile.* files. Create a common Dockerfile

@johnwalicki johnwalicki changed the title Feature Request: Converge on one Dockerfile Feature Request: helloMMS Converge on one Dockerfile Oct 31, 2022
dipesh-rawat added a commit to dipesh-rawat/examples that referenced this issue Jan 22, 2023
@dipesh-rawat
Copy link
Contributor

@johnwalicki Could you please assign this issue to me.
I had a go at making required changes for this issue and created a draft PR #574 with changes. If you could please review the same and let me know if anything is missing.

@johnwalicki
Copy link
Member Author

@dipesh-rawat I have assigned this issue to you

johnwalicki added a commit that referenced this issue Jan 22, 2023
Issue #564 : Add a common helloMMS Converge Dockerfile for all ARCH
@johnwalicki
Copy link
Member Author

Thanks @dipesh-rawat

@johnwalicki
Copy link
Member Author

This change has been released:
https://github.com/open-horizon/examples/releases/tag/v2.30.0-1142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants