-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: helloMMS Converge on one Dockerfile #564
Labels
Comments
dipesh-rawat
added a commit
to dipesh-rawat/examples
that referenced
this issue
Jan 22, 2023
…r all ARCH Signed-off-by: Dipesh Rawat <[email protected]>
@johnwalicki Could you please assign this issue to me. |
@dipesh-rawat I have assigned this issue to you |
johnwalicki
added a commit
that referenced
this issue
Jan 22, 2023
Issue #564 : Add a common helloMMS Converge Dockerfile for all ARCH
Thanks @dipesh-rawat |
This change has been released: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Using the technique described in #560 and implemented in #561
The same can be done for helloMMS
Many of the examples/ repos have
Dockerfile.amd64
/Dockerfile.arm
/Dockerfile.arm64
/Dockerfile.ppc64le
I did a meld on some of these Dockerfiles and they are slightly different. (which is not good)
These multiple Dockerfiles and differences are unnecessary. We could delete them all. Create one common Dockerfile
Then in the
Makefile
, tell the docker build --platform linux/$(ARCH)Docker/Podman will figure out which arch image to pull and build.
Describe the solution you'd like.
Remove all the Dockerfile.* files. Create a common
Dockerfile
The text was updated successfully, but these errors were encountered: