Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable ninja by default #3262

Open
IvDmNe opened this issue Mar 20, 2025 · 0 comments
Open

[Feature] Enable ninja by default #3262

IvDmNe opened this issue Mar 20, 2025 · 0 comments

Comments

@IvDmNe
Copy link

IvDmNe commented Mar 20, 2025

What is the feature?

Currently (in 2.2.0) building wheels invokes ninja if it is installed to parallelize jobs. When building wheels with mim install mmcv (for example, for different python version) only one core is used. And it is not obvious that additionally installing ninja can enable multiprocessing here, leading to very long build time.

What were the reasons not to include ninja as necessary dependency and default option when building wheels?

If it is not possible to enable ninja by default, I suggest to add warning in case ninja is not installed to notify users who want to install mmcv as third-party dependency (I think... almost all users do it this way) about ninja option.

Any other context?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant