Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to configure named resource detectors #119

Open
codeboten opened this issue Sep 9, 2024 · 4 comments
Open

make it possible to configure named resource detectors #119

codeboten opened this issue Sep 9, 2024 · 4 comments

Comments

@codeboten
Copy link
Contributor

It would be great to have the capability to configure resource detectors via the configuration file.

For example, the Collector needs to be able to specify that the environment variable resource detector should be used to address open-telemetry/opentelemetry-collector#10909

@jack-berg
Copy link
Member

In opentelemetry-java we have the ability to enable / disable resource detectors based on name using langauge-specific environment variables: otel.java.[enabled|disabled].resource.providers

The name is the FQCN.

@jack-berg
Copy link
Member

Dotnet auto instrumentation also has resource detector ids: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#resource-detectors

According to @matt-hensley, PHP and JS also have the same concept in auto instrumentation projects.

This all suggests that resource detector names are a "defacto" feature in the spec, despite them not be explicitly written down.

I think we should: 1. Extend the spec to give resource detectors a name / id field. 2. Extend the configuration data model.

@codeboten do you think this is required for stability?

@matt-hensley
Copy link

Additional links:
JavaScript uses OTEL_NODE_RESOURCE_DETECTORS
PHP uses OTEL_PHP_DETECTORS

Also, being able to specify resource detectors via configuration is something end users have requested.

@marcalff
Copy link
Member

Instead of providing a name for a resource detector, should a resource detector be an extension point instead ?

This would be aligned with other parts of the configuration provided as components (custom exporter, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants