Fix SynchronousMetricStorageTest flake #5981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-java into fix-concurrent-test-flake
breedx-splk
reviewed
Nov 13, 2023
.../src/test/java/io/opentelemetry/sdk/metrics/internal/state/SynchronousMetricStorageTest.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5981 +/- ##
============================================
- Coverage 91.18% 91.15% -0.04%
+ Complexity 5613 5612 -1
============================================
Files 616 616
Lines 16566 16566
Branches 1642 1642
============================================
- Hits 15105 15100 -5
- Misses 1013 1015 +2
- Partials 448 451 +3 ☔ View full report in Codecov by Sentry. |
breedx-splk
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SynchronousMetricStorageTest#recordAndCollect_concurrentStressTest can flake if a final iteration of collection doesn't run after all the record threads have finished.
I was able to simulate this failure locally by adding some select
Thread.sleepcalls that increase the probability of flake. Fixing this typo in the test eliminated the flake.