Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Replace deprecated constants DEPLOYMENT_ENVIRONMENT to DEPLOYMENT_ENVIRONMENT_NAME #6377

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[PHP] Replace deprecated constants DEPLOYMENT_ENVIRONMENT to DEPLOYMENT_ENVIRONMENT_NAME #6377

merged 2 commits into from
Feb 19, 2025

Conversation

cm-iwata
Copy link
Contributor

@cm-iwata cm-iwata requested a review from a team as a code owner February 19, 2025 00:12
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 19, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested a review from a team February 19, 2025 00:13
chalin
chalin approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @open-telemetry/php-approvers approve.

@opentelemetrybot opentelemetrybot requested a review from a team February 19, 2025 07:50
@tiffany76 tiffany76 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into open-telemetry:main with commit 0ed24cd Feb 19, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@cm-iwata cm-iwata deleted the fix/php-deprecated-const branch February 20, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@brettmc brettmc brettmc approved these changes

Assignees
No one assigned
Labels
sig:php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cm-iwata @opentelemetrybot @chalin @brettmc @tiffany76