Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI inconsistencies in the logout dialog box #111

Closed
laxyapahuja opened this issue Jan 6, 2020 · 5 comments
Closed

UI inconsistencies in the logout dialog box #111

laxyapahuja opened this issue Jan 6, 2020 · 5 comments

Comments

@laxyapahuja
Copy link

Summary

There are UI inconsistencies in the dialog box when logging out.

Steps to reproduce

Login -> Drawer -> Logout

Expected behaviour

The app should show a dialog box with proper margins and it should follow the Material guidelines.

Observed behaviour

A dialog box appears which has an inconsistent UI and does not follow the Material guidelines.

Device and Android Version

Android 9, Mi A3

Screenshots

@rchtgpt
Copy link
Member

rchtgpt commented Jan 6, 2020

@laxyapahuja this issue cannot be reproduced by others simply because you have changed the AppTheme in the styles.xml from Theme.AppCompat.Light.NoActionBar to Theme.MaterialComponents.Light.NoActionBar in your local branch. Unless #110 gets merged, this issue does not make sense.

@laxyapahuja
Copy link
Author

laxyapahuja commented Jan 6, 2020

@laxyapahuja this issue cannot be reproduced by others simply because you have changed the AppTheme in the styles.xml from Theme.AppCompat.Light.NoActionBar to Theme.MaterialComponents.Light.NoActionBar in your local branch. Unless #110 gets merged, this issue does not make sense.

Thank you for pointing that out. However, I won't take this issue down because the redesign requires us to add Material AppTheme in the project. So, it's going to occur in the future. It's better if we make the app compatible with the Material theme :)

@ashwinkey04
Copy link
Contributor

I think it will be a good idea if this PR is labelled 'later'

@rchtgpt
Copy link
Member

rchtgpt commented Jan 25, 2020

@laxyapahuja, now that #122 has been merged, this issue is reproducible.

@laxyapahuja
Copy link
Author

@luckyman20 can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants