From 6c1d871121d7fc127bee54eeed38ff206d22c089 Mon Sep 17 00:00:00 2001 From: Sk Niyaj Ali Date: Sat, 31 Aug 2024 21:28:25 +0530 Subject: [PATCH] Apply & Fix Detekt, Ktlint Rules in Account Module (#2678) * Apply & Fix Detekt, Ktlint Rules in Account Module Jira Tasks - [MM-64](https://mifosforge.jira.com/browse/MM-64) * Refactor- [:feature:auth] Apply & Fix Detekt, Ktlint Rules Jira Tasks - [MM-65](https://mifosforge.jira.com/browse/MM-65) * Refactor- [:feature:beneficiary] Apply & Fix Detekt, Ktlint Rules Jira Tasks - [MM-66](https://mifosforge.jira.com/browse/MM-66) --- androidApp/src/main/AndroidManifest.xml | 4 +- .../org/mifos/mobile/utils/StatusUtils.kt | 17 +- .../fcm/MifosFirebaseMessagingService.kt | 2 +- .../drawable/ic_wrapped_lock_black_24dp.xml | 2 +- .../drawable/ic_wrapped_person_black_24dp.xml | 2 +- .../src/main/res/layout/activity_login.xml | 6 +- .../src/main/res/layout/fragment_home_old.xml | 2 +- .../src/main/res/layout/fragment_home_ui.xml | 4 +- .../fragment_saving_account_details.xml | 2 +- .../layout/fragment_savings_make_transfer.xml | 2 +- .../layout/fragment_third_party_transfer.xml | 2 +- .../res/layout/fragment_transfer_process.xml | 2 +- .../src/main/res/layout/nav_drawer_header.xml | 2 +- .../res/layout/preference_configuration.xml | 2 +- .../src/main/res/layout/row_share_account.xml | 2 +- androidApp/src/main/res/menu/menu_account.xml | 6 +- .../src/main/res/menu/menu_nav_drawer.xml | 4 +- androidApp/src/main/res/values-ar/strings.xml | 62 +-- androidApp/src/main/res/values-bn/strings.xml | 56 +- androidApp/src/main/res/values-es/strings.xml | 56 +- .../src/main/res/values-fa-rAF/strings.xml | 74 +-- androidApp/src/main/res/values-fr/strings.xml | 56 +- androidApp/src/main/res/values-hi/strings.xml | 78 +-- androidApp/src/main/res/values-in/strings.xml | 56 +- androidApp/src/main/res/values-km/strings.xml | 56 +- androidApp/src/main/res/values-kn/strings.xml | 56 +- androidApp/src/main/res/values-my/strings.xml | 62 +-- androidApp/src/main/res/values-pl/strings.xml | 56 +- androidApp/src/main/res/values-pt/strings.xml | 62 +-- androidApp/src/main/res/values-ru/strings.xml | 56 +- androidApp/src/main/res/values-sw/strings.xml | 56 +- androidApp/src/main/res/values-te/strings.xml | 58 +-- androidApp/src/main/res/values-ur/strings.xml | 62 +-- androidApp/src/main/res/values/strings.xml | 92 ++-- .../src/main/res/xml/settings_preference.xml | 2 +- .../kotlin/AndroidFeatureConventionPlugin.kt | 2 + .../kotlin/AndroidLintConventionPlugin.kt | 5 +- ci-prebuild.sh | 2 +- config/detekt/detekt.yml | 4 +- .../mobile/core/common/utils/DateHelper.kt | 6 +- .../{MifosTextButton.kt => MifosButton.kt} | 16 +- .../components/MifosOutlinedTextField.kt | 2 - .../components/MifosSearchTextField.kt | 32 +- .../core/designsystem/icons/MifosIcons.kt | 6 + .../mifos/mobile/core/ui/utils/ColorUtils.kt | 24 + feature/about/build.gradle.kts | 2 +- .../mobile/feature/about/ui/AboutUsHeader.kt | 6 +- .../mobile/feature/about/ui/AboutUsScreen.kt | 26 +- .../feature/about/ui/PrivacyPolicyScreen.kt | 11 +- ...aw_icon.xml => feature_about_law_icon.xml} | 0 ...y.xml => feature_about_privacy_policy.xml} | 0 ...code.xml => feature_about_source_code.xml} | 0 ..._website.xml => feature_about_website.xml} | 0 feature/about/src/main/res/values/strings.xml | 27 +- feature/account/build.gradle.kts | 21 +- feature/account/src/main/AndroidManifest.xml | 11 +- .../account/account/screens/AccountsScreen.kt | 116 +++-- .../account/screens/LoanAccountContent.kt | 94 ++-- .../account/screens/SavingsAccountContent.kt | 72 +-- .../account/screens/ShareAccountContent.kt | 54 +- .../account/utils/AccountTypeItemIndicator.kt | 31 +- .../account/utils/AccountsFilterUtil.kt | 41 +- .../screens/ClientAccountsScreen.kt | 199 +++---- .../utils/ClientAccountFilterDialog.kt | 152 ++++++ .../utils/ClientAccountScreenTopBar.kt | 71 +-- .../utils/ClientAccountFilterDialog.kt | 124 ----- .../account/navigation/AccountNavGraph.kt | 30 +- .../account/navigation/AccountNavigation.kt | 22 +- .../feature/account/utils/AccountState.kt | 12 +- .../feature/account/utils/StatusUtils.kt | 52 +- .../account/viewmodel/AccountsViewModel.kt | 312 +++++------ ...dp.xml => feature_account_error_black.xml} | 10 + .../account/src/main/res/values/colors.xml | 57 +-- .../account/src/main/res/values/strings.xml | 77 +-- feature/auth/build.gradle.kts | 21 +- .../feature/auth/ExampleInstrumentedTest.kt | 24 - feature/auth/src/main/AndroidManifest.xml | 9 + .../feature/auth/login/screens/LoginScreen.kt | 190 ++++--- .../auth/login/viewmodel/LoginViewModel.kt | 20 +- .../auth/navigation/AuthenticationNavGraph.kt | 35 +- .../AuthenticationNavigationScreen.kt | 18 +- .../screens/RegistrationScreen.kt | 484 +++++++++--------- .../screens/RegistrationVerificationScreen.kt | 140 ++--- .../registration/utils/PasswordStrength.kt | 118 ++--- .../viewmodel/RegistrationViewModel.kt | 38 +- ...ck_24dp.xml => feature_auth_ic_person.xml} | 10 + ...k_black_24dp.xml => feature_auth_lock.xml} | 10 + ...s_logo.png => feature_auth_mifos_logo.png} | Bin feature/auth/src/main/res/values/strings.xml | 9 + .../auth/src/main/res/values/validations.xml | 9 + .../mobile/feature/auth/ExampleUnitTest.kt | 17 - feature/beneficiary/build.gradle.kts | 22 +- .../beneficiary/ExampleInstrumentedTest.kt | 24 - .../beneficiary/src/main/AndroidManifest.xml | 9 + .../BeneficiaryApplicationContent.kt | 122 +++-- .../BeneficiaryApplicationScreen.kt | 79 +-- .../BeneficiaryApplicationViewModel.kt | 68 ++- .../BeneficiaryDetailContent.kt | 56 +- .../BeneficiaryDetailScreen.kt | 118 ++--- .../BeneficiaryDetailViewModel.kt | 35 +- .../BeneficiaryListContent.kt | 55 +- .../BeneficiaryListScreen.kt | 73 +-- .../BeneficiaryListViewModel.kt | 33 +- .../navigation/BeneficiaryNavGraph.kt | 76 ++- .../navigation/BeneficiaryNavigationScreen.kt | 24 +- .../presentation/BeneficiaryScreen.kt | 57 +-- .../presentation/BeneficiaryScreenIcons.kt | 71 ++- .../presentation/RenderIconAndText.kt | 67 +-- .../main/res/drawable/ic_add_white_24dp.xml | 10 + .../res/drawable/ic_beneficiary_add_48px.xml | 10 + .../main/res/drawable/ic_error_black_24dp.xml | 10 + .../drawable/ic_file_upload_black_24dp.xml | 10 + .../res/drawable/ic_qrcode_scan_gray_dark.xml | 10 + .../src/main/res/values/strings.xml | 9 + .../feature/beneficiary/ExampleUnitTest.kt | 17 - .../ThirdPartyTransferContent.kt | 10 +- gradle/libs.versions.toml | 2 + lint/build.gradle.kts | 3 + 118 files changed, 2737 insertions(+), 2343 deletions(-) rename core/designsystem/src/main/kotlin/org/mifos/mobile/core/designsystem/components/{MifosTextButton.kt => MifosButton.kt} (84%) create mode 100644 core/ui/src/main/java/org/mifos/mobile/core/ui/utils/ColorUtils.kt rename feature/about/src/main/res/drawable/{ic_law_icon.xml => feature_about_law_icon.xml} (100%) rename feature/about/src/main/res/drawable/{ic_privacy_policy.xml => feature_about_privacy_policy.xml} (100%) rename feature/about/src/main/res/drawable/{ic_source_code.xml => feature_about_source_code.xml} (100%) rename feature/about/src/main/res/drawable/{ic_website.xml => feature_about_website.xml} (100%) rename feature/account/src/main/java/org/mifos/mobile/feature/account/{client_account => clientAccount}/screens/ClientAccountsScreen.kt (70%) create mode 100644 feature/account/src/main/java/org/mifos/mobile/feature/account/clientAccount/utils/ClientAccountFilterDialog.kt rename feature/account/src/main/java/org/mifos/mobile/feature/account/{client_account => clientAccount}/utils/ClientAccountScreenTopBar.kt (67%) delete mode 100644 feature/account/src/main/java/org/mifos/mobile/feature/account/client_account/utils/ClientAccountFilterDialog.kt rename feature/account/src/main/res/drawable/{ic_error_black_24dp.xml => feature_account_error_black.xml} (51%) delete mode 100644 feature/auth/src/androidTest/java/org/mifos/mobile/feature/auth/ExampleInstrumentedTest.kt rename feature/auth/src/main/res/drawable/{ic_person_black_24dp.xml => feature_auth_ic_person.xml} (52%) rename feature/auth/src/main/res/drawable/{ic_lock_black_24dp.xml => feature_auth_lock.xml} (62%) rename feature/auth/src/main/res/drawable/{mifos_logo.png => feature_auth_mifos_logo.png} (100%) delete mode 100644 feature/auth/src/test/java/org/mifos/mobile/feature/auth/ExampleUnitTest.kt delete mode 100644 feature/beneficiary/src/androidTest/java/org/mifos/mobile/feature/beneficiary/ExampleInstrumentedTest.kt rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_application => beneficiaryApplication}/BeneficiaryApplicationContent.kt (68%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_application => beneficiaryApplication}/BeneficiaryApplicationScreen.kt (72%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_application => beneficiaryApplication}/BeneficiaryApplicationViewModel.kt (69%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_detail => beneficiaryDetail}/BeneficiaryDetailContent.kt (71%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_detail => beneficiaryDetail}/BeneficiaryDetailScreen.kt (74%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_detail => beneficiaryDetail}/BeneficiaryDetailViewModel.kt (73%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_list => beneficiaryList}/BeneficiaryListContent.kt (70%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_list => beneficiaryList}/BeneficiaryListScreen.kt (81%) rename feature/beneficiary/src/main/java/org/mifos/mobile/feature/beneficiary/{beneficiary_list => beneficiaryList}/BeneficiaryListViewModel.kt (64%) delete mode 100644 feature/beneficiary/src/test/java/org/mifos/mobile/feature/beneficiary/ExampleUnitTest.kt diff --git a/androidApp/src/main/AndroidManifest.xml b/androidApp/src/main/AndroidManifest.xml index 8a4a7038b..5789de63f 100644 --- a/androidApp/src/main/AndroidManifest.xml +++ b/androidApp/src/main/AndroidManifest.xml @@ -19,7 +19,7 @@ android:name=".MifosSelfServiceApp" android:allowBackup="true" android:icon="@mipmap/core_common_mifos_icon" - android:label="@string/app_name" + android:label="@string/feature_about_app_name" android:supportsRtl="true" android:theme="@style/AppTheme" tools:ignore="GoogleAppIndexingWarning"> @@ -36,7 +36,7 @@ () arrayList.add( CheckboxStatus( - context?.getString(R.string.deposit), + context?.getString(R.string.feature_account_deposit), ContextCompat .getColor(context!!, R.color.deposit_green), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.dividend_payout), + context.getString(R.string.feature_account_dividend_payout), ContextCompat .getColor(context, R.color.red_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.withdrawal), + context.getString(R.string.feature_account_withdrawal), ContextCompat .getColor(context, R.color.red_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.interest_posting), + context.getString(R.string.feature_account_interest_posting), ContextCompat.getColor(context, R.color.green_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.fee_deduction), + context.getString(R.string.feature_account_fee_deduction), ContextCompat .getColor(context, R.color.red_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.withdrawal_transfer), + context.getString(R.string.feature_account_withdrawal_transfer), ContextCompat.getColor(context, R.color.red_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.rejected_transfer), + context.getString(R.string.feature_account_rejected_transfer), ContextCompat.getColor(context, R.color.green_light), ), ) arrayList.add( CheckboxStatus( - context.getString(R.string.overdraft_fee), + context.getString(R.string.feature_account_overdraft_fee), ContextCompat .getColor(context, R.color.red_light), ), diff --git a/androidApp/src/main/java/org/mifos/mobile/utils/fcm/MifosFirebaseMessagingService.kt b/androidApp/src/main/java/org/mifos/mobile/utils/fcm/MifosFirebaseMessagingService.kt index 3f2ef6ad4..39523e0cc 100644 --- a/androidApp/src/main/java/org/mifos/mobile/utils/fcm/MifosFirebaseMessagingService.kt +++ b/androidApp/src/main/java/org/mifos/mobile/utils/fcm/MifosFirebaseMessagingService.kt @@ -62,7 +62,7 @@ class MifosFirebaseMessagingService : FirebaseMessagingService() { val defaultSoundUri = RingtoneManager.getDefaultUri(RingtoneManager.TYPE_NOTIFICATION) val notificationBuilder = NotificationCompat.Builder(this) .setSmallIcon(R.mipmap.core_common_mifos_icon) - .setContentTitle(getString(R.string.app_name)) + .setContentTitle(getString(R.string.feature_about_app_name)) .setContentText(message) .setAutoCancel(true) .setSound(defaultSoundUri) diff --git a/androidApp/src/main/res/drawable/ic_wrapped_lock_black_24dp.xml b/androidApp/src/main/res/drawable/ic_wrapped_lock_black_24dp.xml index d2a2d1913..f0b49c99e 100644 --- a/androidApp/src/main/res/drawable/ic_wrapped_lock_black_24dp.xml +++ b/androidApp/src/main/res/drawable/ic_wrapped_lock_black_24dp.xml @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/androidApp/src/main/res/drawable/ic_wrapped_person_black_24dp.xml b/androidApp/src/main/res/drawable/ic_wrapped_person_black_24dp.xml index fde1e3a50..0b1822d0a 100644 --- a/androidApp/src/main/res/drawable/ic_wrapped_person_black_24dp.xml +++ b/androidApp/src/main/res/drawable/ic_wrapped_person_black_24dp.xml @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/androidApp/src/main/res/layout/activity_login.xml b/androidApp/src/main/res/layout/activity_login.xml index 11d86841a..6d2c55418 100644 --- a/androidApp/src/main/res/layout/activity_login.xml +++ b/androidApp/src/main/res/layout/activity_login.xml @@ -19,13 +19,13 @@ android:layout_height="@dimen/Mifos.DesignSystem.Size.LogoImageSize" android:layout_gravity="center_horizontal" android:layout_marginVertical="@dimen/Mifos.DesignSystem.Size.LogoImageVerticalMargin" - app:srcCompat="@drawable/mifos_logo" /> + app:srcCompat="@drawable/feature_auth_mifos_logo" /> + app:startIconDrawable="@drawable/feature_auth_ic_person"> + app:startIconDrawable="@drawable/feature_auth_lock"> + tools:src="@drawable/feature_auth_ic_person" /> + app:srcCompat="@drawable/feature_auth_ic_person" /> + tools:src="@drawable/feature_auth_ic_person" /> + android:text="@string/feature_account_deposit" />