#1645 fixed the error in the EditPasswordScreen.kt regarding the Mif… #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osScaffold.kt Composable Issues Fix Fixes #1646 Description The EditPasswordScreen.kt had some errors related to the composable MifosScaffold.k where the scaffold content was not being passed as one of the arguments required by the Composable. The error was fixed along with teh help of @PratyushSingh07.
|
Add video of before and after |
Actually It was not an UI issue there was an error in that file the project was not building due to it. One of the parameters of the function used was missing which was causing the error. |
|
@PratyushSingh07 review |
|
Already reviewed @therajanmaurya . I had connected with him over a call and then he had made these changes in my presence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fix
Fixes #1646
Description
The EditPasswordScreen.kt had some errors related to the composable MifosScaffold.k where the scaffold content was not
being passed as one of the arguments required by the Composable. The error was fixed along with teh help of
@PratyushSingh07.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.