Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing opportunity data errors to include specific numbers #684

Open
nickevansuk opened this issue Apr 23, 2024 · 0 comments
Open

Comments

@nickevansuk
Copy link
Collaborator

nickevansuk commented Apr 23, 2024

Referencing this discussion: #647 (comment)

❌ Missing Criteria: TestOpportunityBookableFree

  • Opportunity Types: IndividualFacilityUseSlot, ScheduledSession
  • Booking Flows: OpenBookingApprovalFlow, OpenBookingSimpleFlow
  • Sellers: https://localhost:5001/api/identifiers/sellers/1
  • Tests failing as a result: 72

Suggest this should be:

❌ Missing Criteria: TestOpportunityBookableFree

  • Sellers: https://localhost:5001/api/identifiers/sellers/1
  • Tests failing as a result:
    • IndividualFacilityUseSlot for OpenBookingApprovalFlow: 18
    • ScheduledSession for OpenBookingApprovalFlow: 18
    • IndividualFacilityUseSlot for OpenBookingSimpleFlow: 18
    • ScheduledSession for OpenBookingSimpleFlow: 18

As the Seller in use is configured in the test suite, there will generally be one of these. As the test data for sessions and facilities, approval and simple, are often provided separately, it likely helpful to have a quick breakdown of where the gaps are - so they can easily add more data if they need to without needing to inspect the results.

Additionally there will generally be a maximum of 4 permutations (though most implementations will likely only have 1 or 2), which makes the combinatorial explosion much less of a risk.

@nickevansuk nickevansuk moved this from 💡Ideas to ❗ High Priority Ideas in OpenActive Infrastructure Apr 23, 2024
@nickevansuk nickevansuk changed the title Improve missing opportunity data errors to include numbers in brackets Improve missing opportunity data errors to include specific numbers Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ❗ High Priority Ideas
Development

No branches or pull requests

1 participant