Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download of video by a right click should not be possible #293

Closed
dagraf opened this issue Jun 12, 2024 · 7 comments
Closed

Download of video by a right click should not be possible #293

dagraf opened this issue Jun 12, 2024 · 7 comments
Assignees
@chfsx @ferishili
Labels
bug Something isn't working ILIAS 7 Issue appears or may only appear on ILIAS 7. ILIAS 8 Issue appears or may only appear on ILIAS 8. Priority: High Needs to be fixed/taken care of asap

Comments

@dagraf
Copy link

dagraf commented Jun 12, 2024

Describe the bug
With Paella 7, the videos can be downloaded using the right click and then "Save video". This should not be the case.

To Reproduce
Steps to reproduce the behavior:

  1. Open a video
  2. Make a right click
  3. Choose "Save video as"

Expected behavior
It should not be possible to download the video that easily. Possible solution: The right click

Environment (please complete the following information):

  • ILIAS version: v8.12 2024-05-28
  • Plugin version: 8.0.5
  • Opencast version: 15
  • Browser: Firefox

Additional context
It might be a solution, to make changes in paella-player.js (under: Prevent video download).
@dagraf dagraf added bug Something isn't working Priority: High Needs to be fixed/taken care of asap ILIAS 8 Issue appears or may only appear on ILIAS 8. ILIAS 7 Issue appears or may only appear on ILIAS 7. labels Jun 12, 2024
@dagraf
Copy link
Author

dagraf commented Jun 12, 2024

Same question as in #289:

@chfsx Is this a bug you would fix or should we ask @ferishili to do so, since it concerns the Paella player?

@ferishili
Copy link
Contributor

Since it is Paella related, I will take a look, but not sure if that is easy to prevent

@dagraf
Copy link
Author

dagraf commented Jun 12, 2024

It is prevented in Paella 7 on our Opencast 15 we run on our Test-Opencast.

@reiferschris
Copy link
Contributor

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md
@dagraf have you implemented this change from the docs?
Or are you referring to the fact that you don't use mp4 but instead stream via hls?

@dagraf
Copy link
Author

dagraf commented Jun 12, 2024 •
edited
Loading

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md @dagraf have you implemented this change from the docs? Or are you referring to the fact that you don't use mp4 but instead stream via hls?

@snoesberger: Can you answer @reiferschris question?

@snoesberger
Copy link

Paella docs regarding this are here: https://paellaplayer.upv.es/#/doc/mp4_video_plugin.md @dagraf have you implemented this change from the docs? Or are you referring to the fact that you don't use mp4 but instead stream via hls?

In Opencast this can easily be configured with the preventVideoDownloadparameter in the Paella config file config.json. Setting this parameter to true will disable the right click menu in the player. It doesn't matter if you use mp4 or hls.

ferishili added a commit to elan-ev/ilias-opencast-plugin that referenced this issue Jun 13, 2024
@ferishili
paella improvements
ceed88c 
fixes opencast-ilias#289,
fixes opencast-ilias#292,
fixes opencast-ilias#293,
fixes opencast-ilias#294
@ferishili ferishili mentioned this issue Jun 13, 2024
Merged
ferishili added a commit to elan-ev/ilias-opencast-plugin that referenced this issue Jun 13, 2024
@ferishili
paella improvements
e13232e 
refs opencast-ilias#289,
refs opencast-ilias#292,
refs opencast-ilias#293,
refs opencast-ilias#294
@ferishili ferishili mentioned this issue Jun 13, 2024
Merged
@dagraf
Copy link
Author

dagraf commented Jun 13, 2024

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@dagraf dagraf closed this as completed Jun 13, 2024
okaufman added a commit to okaufman/OpenCast that referenced this issue Jun 14, 2024
@okaufman
Merge branch 'release_8' into ilias8_pr277
444bb68 
* release_8:
  [RELEASE] new Version v8.0.7
  [RELEASE] new Version v8.0.6
  install paella-user-tracking v1.42.4
  upgrade opencast-api lib to v1.7 fixes opencast-ilias#298
  paella improvements fixes opencast-ilias#289, fixes opencast-ilias#292, fixes opencast-ilias#293, fixes opencast-ilias#294
  improve livestream config, refs opencast-ilias#286
  [FIX] correct supports_cli variable (did support cli setup anyway)
  [RELEASE] new Version v8.0.5
  [FIX] compatibility issue with EULA section in form
  [FIX] removed double strict-types declarations
  [FIX] make code compliant to the ILIAS 7 version
okaufman added a commit to ilub-unibe-ch/OpenCast that referenced this issue Aug 5, 2024
@okaufman
Merge branch 'release_8' into ilias8
a4b5d8f 
* release_8:
  [RELEASE] Version v8.1.1
  [FIX] bad merge conflict leads to error in StandardPlayerDataBuilder opencast-ilias#324
  [RELEASE] Version v8.1.0
  [Release 8] OCT Text feature opencast-ilias#290
  [Release 8] Upload Thumbnail (Preview) opencast-ilias#305
  [Release 8] Upload Subtitles opencast-ilias#277
  [Release 8] New Right management opencast-ilias#301
  [RELEASE] new Version v8.0.7
  [RELEASE] new Version v8.0.6
  install paella-user-tracking v1.42.4
  upgrade opencast-api lib to v1.7 fixes opencast-ilias#298
  paella improvements fixes opencast-ilias#289, fixes opencast-ilias#292, fixes opencast-ilias#293, fixes opencast-ilias#294
  improve livestream config, refs opencast-ilias#286
  [FIX] correct supports_cli variable (did support cli setup anyway)
  [RELEASE] new Version v8.0.5
  [FIX] compatibility issue with EULA section in form
  [FIX] removed double strict-types declarations
  [FIX] make code compliant to the ILIAS 7 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfsx chfsx

@ferishili ferishili

Labels
bug Something isn't working ILIAS 7 Issue appears or may only appear on ILIAS 7. ILIAS 8 Issue appears or may only appear on ILIAS 8. Priority: High Needs to be fixed/taken care of asap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chfsx @dagraf @reiferschris @ferishili @snoesberger