oc-wifi-mac: mfp leaf - wrong usage of mandatory true

[precla]

regarding mfp:

public/release/models/wifi/openconfig-wifi-mac.yang

Line 399 in 850e572

leaf mfp {

based on this change: #607 and this comment https://github.com/openconfig/public/pull/607/files#r842092645

What "mandatory true" does here is say "if opmode is any of these 3, then this MUST be set to true".

@mike-albano @deecortes the mandatory true means that the leaf is mandatory, not the value. This needs to be changed to a must check, something like:

must "(
            (../opmode = 'WPA3_ENTERPRISE' or
               ../opmode = 'WPA3_2_ENTERPRISE_TRANSITION' or
               ../opmode = 'WPA3_ENTERPRISE_192_BIT' or
               ../opmode = 'WPA3_SAE' or
               ../opmode = 'WPA3_2_SAE_TRANSITION' or
               ../opmode = 'ENHANCED_OPEN' or
               ../opmode = 'ENHANCED_OPEN_TRANSITION')
               and
              (. = 'true')
            ) or (
             // all other opmodes that don't need mfp to be set to true
            )
)"

afaik, mfp can be false for all opmodes. It is only mandatory to be true if one wants wifi certification. So i guess it's not needed to be mandatory at all and no further checks are needed?

https://www.wi-fi.org/beacon/philipp-ebbecke/protected-management-frames-enhance-wi-fi-network-security