Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "period of no metrics" in monitor-pv exporter #5

Open
ksatchit opened this issue May 15, 2020 · 0 comments · May be fixed by #13
Open

Fix "period of no metrics" in monitor-pv exporter #5

ksatchit opened this issue May 15, 2020 · 0 comments · May be fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@ksatchit
Copy link

Both the functions collect_pv_capacity_metrics() & collect_pv_utilization_metrics() first clear the respective textfiles holding the metrics info before recreating them with latest updated info. However, the procedure to derive these metrics involves kubectl commands and/or system calls with some output parsing. Under cases where these take more than a few seconds & if the prometheus scrape interval is such that it coincides with this state of the textfiles (empty), then the dashboards are prone to show a few seconds worth of "no-metrics". This manifests itself like shown below:

image

This should be fixed. The changes may occur in two phases:

  • The existing bash script will be updated to replace metrics over clearing files
  • The collection approach maybe rewritten in golang
@ksatchit ksatchit added the bug Something isn't working label May 15, 2020
@ksatchit ksatchit self-assigned this May 15, 2020
@applejag applejag linked a pull request Oct 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant