Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #510 #511

Closed
wants to merge 2 commits into from
Closed

Fixed issue #510 #511

wants to merge 2 commits into from

Conversation

Ankush1oo8
Copy link

Fixed the issue and added the main element ID "main"

@Ankush1oo8 Ankush1oo8 requested a review from a team as a code owner November 21, 2024 19:21
@openedx-webhooks
Copy link

Thanks for the pull request, @Ankush1oo8!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2024
@deborahgu
Copy link
Member

Thanks for the quick fix, @Ankush1oo8!

The actual fix here looks good, but there's some cleanup to make it approvable. This is covered in our Quick Start: First Open edX Pull Request doc if you want more details.

Non-blocking changes

These are things to just know for your next openEdx commit (and I hope there are more 😄 ).

  • You included many format changes (probably automatically produced by your IDE settings when you saved the file). As a general rule it's good to avoid this.
    • Sometimes I want to lint an existing file, so what I will do is make 2 separate pull requests, so the reviewer knows that one is style only.
  • We use Conventional Commits for commit messages.

Blocking changes

  • Your format changes don't match our existing shared code-style.
    • Now that the github actions have run you should be able to see those error messages.
    • The easiest way to fix those errors is to just revert all the style changes.
    • Most IDEs have a "save without formatting" option. In VS Code it's in the command palette.
  • We'll need you to sign the Contributor License Agreement

@deborahgu deborahgu added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. engineering review labels Nov 21, 2024
@Ankush1oo8
Copy link
Author

So should I change it and again send the PR

@Ankush1oo8
Copy link
Author

Or will you change the format

@deborahgu
Copy link
Member

So should I change it and again send the PR

If you change the PR to remove the formatting changes, then I will test the fix locally.

Assuming it works (which is looks like it will, but I have to verify) then as soon as we have your signed contributor agreement, I can approve.

@Ankush1oo8
Copy link
Author

Okey I have filled the form for contributing

@Ankush1oo8 Ankush1oo8 closed this Nov 22, 2024
@Ankush1oo8
Copy link
Author

I have made changes you told in a new pr please check it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering review open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants