-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #510 #511
Fixed issue #510 #511
Conversation
Thanks for the pull request, @Ankush1oo8! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Thanks for the quick fix, @Ankush1oo8! The actual fix here looks good, but there's some cleanup to make it approvable. This is covered in our Quick Start: First Open edX Pull Request doc if you want more details. Non-blocking changesThese are things to just know for your next openEdx commit (and I hope there are more 😄 ).
Blocking changes
|
So should I change it and again send the PR |
Or will you change the format |
If you change the PR to remove the formatting changes, then I will test the fix locally. Assuming it works (which is looks like it will, but I have to verify) then as soon as we have your signed contributor agreement, I can approve. |
Okey I have filled the form for contributing |
I have made changes you told in a new pr please check it |
Fixed the issue and added the main element ID "main"