Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fga write --file should not always display the imported tuples #376

Closed
aaguiarz opened this issue Aug 14, 2024 · 5 comments · Fixed by #437
Closed

fga write --file should not always display the imported tuples #376

aaguiarz opened this issue Aug 14, 2024 · 5 comments · Fixed by #437
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aaguiarz
Copy link
Member

When you import a large number of tuples, seeing all the importing ones at the end of the import process is not practical.

We should either stop returning imported tuples and only return the failed ones, or add a new option like

fga write --file tuples.yaml --hide-imported-tuples

We should also display a summary of the total number of imported/failed tuples if possible.
@aaguiarz aaguiarz added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 8, 2025
@Siddhant-K-code Siddhant-K-code mentioned this issue Jan 8, 2025
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in SDKs and Tooling Jan 22, 2025
@Siddhant-K-code
Copy link
Contributor

@ewanharris, can we cut a new release?

@ewanharris
Copy link
Member

Released in v0.6.3, thanks again @Siddhant-K-code!

@Siddhant-K-code
Copy link
Contributor

Thanks for the PR reviews & release 🚀

@Siddhant-K-code
Copy link
Contributor

@ewanharris, I think we can merge our docs PR too: openfga/openfga.dev#926

@ewanharris
Copy link
Member

Ah I'd overlooked that PR, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
SDKs and Tooling
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to hide successful tuple imports and display import summary Siddhant-K-code/openfga-cli
3 participants
@aaguiarz @ewanharris @Siddhant-K-code