Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support start time parameter on read changes #443

Conversation

ryanpq
Copy link
Contributor

@ryanpq ryanpq commented Jan 23, 2025

Description

Adds support for start_time parameter in read changes

References

openfga/go-sdk#158

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq ryanpq requested review from a team as code owners January 23, 2025 19:06
Copy link

stacklok-cloud bot commented Jan 30, 2025

Minder Vulnerability Report ✅

Minder analyzed this PR and found it does not add any new vulnerable dependencies.

Vulnerability scan of b00b8b30:

  • 🐞 vulnerable packages: 0
  • 🛠 fixes available for: 0

feat: support start time parameter on read changes
@ryanpq ryanpq force-pushed the feat-support-start-time-parameter-on-read-changes branch from 20718e8 to a1f7cbb Compare January 31, 2025 15:18
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a query around the format the CLI accepts

README.md Outdated Show resolved Hide resolved
cmd/tuple/changes.go Outdated Show resolved Hide resolved
Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

feat: use RFC3339 in place of ISO8601 layout string

fix: resolve linting error from newline

docs: Update changelog with start time and prep for 0.6.4 release
@ryanpq ryanpq force-pushed the feat-support-start-time-parameter-on-read-changes branch from abca66d to b00b8b3 Compare February 6, 2025 21:31
@ewanharris ewanharris added this pull request to the merge queue Feb 7, 2025
Merged via the queue into openfga:main with commit c160fcf Feb 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants