Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "Nutrition" section in full edit mode on Open Beauty Facts ("obf") and Open Products Facts ("opf") #5569

Closed
Tracked by #4540
, #4093
...
teolemon opened this issue Sep 6, 2024 · 2 comments · Fixed by #5593
Closed
Tracked by #4540
, #4093
...

Disable "Nutrition" section in full edit mode on Open Beauty Facts ("obf") and Open Products Facts ("opf") #5569

teolemon opened this issue Sep 6, 2024 · 2 comments · Fixed by #5593
Assignees
@monsieurtanuki
Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts

Comments

@teolemon
Copy link
Member

teolemon commented Sep 6, 2024 •
edited
Loading

What

  • Disable "Nutrition" section in full edit mode on Open Beauty Facts ("obf") and Open Products Facts ("opf")

Part of
@teolemon teolemon added 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts labels Sep 6, 2024
@github-project-automation github-project-automation bot moved this to To Discuss & Validate in 🧴 Open Beauty Facts Sep 6, 2024
This was referenced Sep 11, 2024
Open
Open
@monsieurtanuki
Copy link
Contributor

@teolemon First tests:

  • when looking for a barcode, we try food then after automatically we try beauty
  • for a beauty product, no nutrition and an "edit" icon for the categories
before after
Screenshot_1726318842 Screenshot_1726319771
Screenshot_1726319889 Screenshot_1726320469

@teolemon
Copy link
Member Author

That sounds good 👍 . We actually stored fluoride as a nutrient at some point, but at this moment let's disable nutrition alltogether. @monsieurtanuki

@monsieurtanuki monsieurtanuki self-assigned this Sep 18, 2024
@monsieurtanuki monsieurtanuki mentioned this issue Sep 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from To Discuss & Validate to Done in 🧴 Open Beauty Facts Sep 25, 2024
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 25, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in 📸 Open Products Facts Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 📸 Open Products Facts
Projects
📸 Open Products Facts
Archived in project
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
🧴 Open Beauty Facts
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 5576 - first step towards multi product types monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki