-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Producers: Certifications filter (add 'All Certifications' option on API) #69
Comments
I think you are suggesting in Slack that there are potentially two problems here: one is the same as the Supporting Evidence filter (i.e. in the framework at your end) and the other could be related to data. Can you tell us any more about your hunch with data - is there anything @maikel can investigate or this is really with you? |
@mkllnk already fixed the issue with the datas. Maybe there are something more but for now it's all on Startin'blox end. |
Great, thanks |
Fixed! |
Hurray!! Getting there! Couple of comments |
For reference.
|
@mkllnk can you please implement an 'all Certifications' option on the API so that it can appear on the filter |
it should be shown at the top of the list |
Added 'all Certifications' option in the API. |
What needs to be fixed? |
not sure if it requires @rioug or @JbPasquier, apologies. the option in the dropdown is now coming through BUT it doesn't filter as it should (doesn't show any producer) you can test it here https://regenerative.org.au/directory/ |
Is this back to @mkllnk or @JbPasquier ? |
When 'All Certifications' is selected, it should show every Producer that
has a certification (any one of them)
…On Wed, 17 Apr 2024 at 10:18, mariocarabotta ***@***.***> wrote:
not sure if it requires @rioug <https://github.com/rioug> or @JbPasquier
<https://github.com/JbPasquier>, apologies.
the option in the dropdown is now coming through BUT it doesn't filter as
it should (doesn't show any producer)
Screenshot.2024-04-17.at.9.14.16.png (view on web)
<https://github.com/openfoodfoundation/openfoodnetwork/assets/6696729/99a149c7-e57f-44ab-ae98-a471b23f8486>
you can test it here https://regenerative.org.au/directory/
—
Reply to this email directly, view it on GitHub
<#69>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAWGXSD2YSY725BD2DXNMXDY5W5TZAVCNFSM6AAAAABEJ4S3WCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGEYDKMRQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@JbPasquier If am not mistaken the filtering is handled by the component, so the filtering should to be fixed as explained above :
|
The filtering is data-driven. If your producer datas does not include this entry on their certifications, then it'll not be filtered. |
I'm not sure how we proceed here. Right now we have a filter by certain certification types. We added a special "All Certifications" option to the list and we would like it to show all producers that have any certification. @JbPasquier, you are suggesting to add data to the producers. We could do that. So any producer which has a certification would get one additional certification of the type "All Certifications". The problem with this is that it would also appear in other parts of the directory as an actual certification, but it's just a dummy entry for the filter. Two possible solutions:
|
it has been decided that we are NOT going to show the All Certification option for the 6th May launch. We will address this more comprehensively together with a few other updates to filters. @rioug to remove the filter option and push this back to Design / Planning / Estimate |
Done. |
@JbPasquier comment on Slack
It seems that there are no relation between https://api.regenerative.org.au/webhook/regen/assurance?id=recllpzAo2WyaVvGz and https://api.regenerative.org.au/webhook/regen/certification?id=Organic
So I have no way to filter those certifications.
Maybe you can replace ofn:Certification_status with an ofn:certification with a value like this {"@id": "https://api.regenerative.org.au/webhook/regen/certification?id=Organic"} ?
@mkllnk thinks there may be a missing attribute, working on this today
The text was updated successfully, but these errors were encountered: