Order export csv #990
Open
Order export csv #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernicPanel
force-pushed
the
order-export-csv
branch
2 times, most recently
from
d9660be to
10ce316
Compare
wilbrdt
reviewed
Dec 11, 2024
kernicPanel
force-pushed
the
order-export-csv
branch
8 times, most recently
from
7b0e4c4 to
57904b6
Compare
jbpenrath
reviewed
Dec 17, 2024
| queryset.iterator(), child=self.get_serializer() | ||
| ) | ||
| now = timezone.now().strftime("%d-%m-%Y_%H-%M-%S") | ||
| return StreamingHttpResponse( |
There was a problem hiding this comment.
According to the time needed to Stream the whole file, I emit some reserve about that as this will block a worker. If you are able to connect your local env to the preproduction database this is something to check IMO.
kernicPanel
force-pushed
the
order-export-csv
branch
4 times, most recently
from
c8068b8 to
ae48642
Compare
wilbrdt
reviewed
Dec 19, 2024
jonathanreveille
approved these changes
Dec 19, 2024
jonathanreveille
approved these changes
Dec 19, 2024
wilbrdt
approved these changes
Dec 19, 2024
jbpenrath
reviewed
Dec 19, 2024
| @@ -19,7 +19,7 @@ export default defineConfig({ | |||
| /* Opt out of parallel tests on CI. */ | |||
| workers: process.env.CI ? 1 : undefined, | |||
| /* Reporter to use. See https://playwright.dev/docs/test-reporters */ | |||
| reporter: "html", | |||
| reporter: "list", | |||
jbpenrath
approved these changes
Dec 19, 2024
As we want to export order csv, an api endpoint is needed.
We want to export the order list using the current filters.
Flaky test retry needs to be increased.
When we start a localtunnel, we don't want to rerun the full stack everytime.
Add data to order export.
Extract demo data generation to use it in order export test.
Reduce log levers to remove noise in console output during tests.
Order export headers were not translated.
Adds a test asserting that orders export allows filtering.
As we have the same logic to get the best available user name, it has been moved to the user model.
kernicPanel
force-pushed
the
order-export-csv
branch
from
9e5a405 to
9e0abb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Export filtered orders as csv
Fixes #980