Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic equipment tag on things #4614

Open
andrewfg opened this issue Feb 22, 2025 · 4 comments · May be fixed by #4617
Open

Add semantic equipment tag on things #4614

andrewfg opened this issue Feb 22, 2025 · 4 comments · May be fixed by #4617
Labels
enhancement An enhancement or new feature of the Core

Comments

@andrewfg
Copy link
Contributor

andrewfg commented Feb 22, 2025 •
edited
Loading

Add support for tag element to thing type description xml.
In addition to, and analogous to, to the already existing tags for channel type descriptions.

The purpose is that thing definitions could define default 'Equipment' tags, in the same way as channel can define default 'Point'.

See openhab/openhab-docs#2466
See https://community.openhab.org/t/openhab-5-semantic-model-proposal/162526/83

Thing Type Definition (New)

<thing-type id="device">
    <supported-bridge-type-refs>
        <bridge-type-ref id="bridge-api2"/>
    </supported-bridge-type-refs>
    <label>Hue Device</label>
    <description>A Hue API v2 device with channels depending on its actual capabilities.</description>
    <semantic-equipment-tag>equipment.tag.name</semantic-equipment-tag>
    <channels>
        <channel id="illuminance" typeId="type-illuminance"/>
    </channels>
</thing-type>

Channel Type Definition (Already Existing)

<channel-type id="type-illuminance">
    <item-type>Number:Illuminance</item-type>
    <label>Illuminance</label>
    <description>Current illuminance.</description>
    <tags>
        <tag>point.tag.name</tag>
        <tag>property.tag.name</tag>
    </tags>
</channel-type>
@andrewfg andrewfg added the enhancement An enhancement or new feature of the Core label Feb 22, 2025
@andrewfg
Copy link
Contributor Author

This would need to be updated too https://www.openhab.org/docs/developer/bindings/thing-xml.html

@andrewfg andrewfg mentioned this issue Feb 22, 2025
Open
@andrewfg
Copy link
Contributor Author

@jimtng I created the issue wrong in OH-docs so recreated it again here..

@andrewfg andrewfg changed the title Add support for tag element to thing type description xml Add support for semantic tag element to thing type description xml Feb 25, 2025
@andrewfg andrewfg linked a pull request Feb 28, 2025 that will close this issue
Open
@andrewfg andrewfg changed the title Add support for semantic tag element to thing type description xml Add support for semantic equipment tag element to thing description xml Feb 28, 2025
@andrewfg andrewfg changed the title Add support for semantic equipment tag element to thing description xml Add support for semantic equipment tag element to thing xml Feb 28, 2025
@clinique
Copy link
Contributor

clinique commented Mar 1, 2025

Adding semantic tags to thing goes in the direction of a PR I did some times ago : #3467 to add icons to things. This would IMHO make end user experience more satisfying.

@andrewfg
Copy link
Contributor Author

andrewfg commented Mar 1, 2025

This would IMHO make end user experience more satisfying.

=> #4617 :)

@andrewfg andrewfg changed the title Add support for semantic equipment tag element to thing xml Add support for semantic equipment tag element to things Mar 1, 2025
@andrewfg andrewfg changed the title Add support for semantic equipment tag element to things Add support for semantic equipment tag on things Mar 1, 2025
@andrewfg andrewfg changed the title Add support for semantic equipment tag on things Add semantic equipment tag on things Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add semantic equipment tag on things andrewfg/openhab-core
2 participants
@andrewfg @clinique