Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section of Wallet invocation #201

Closed
paulbastian opened this issue Jan 4, 2024 · 3 comments · Fixed by #380
Closed

Add a section of Wallet invocation #201

paulbastian opened this issue Jan 4, 2024 · 3 comments · Fixed by #380
Labels

Comments

@paulbastian
Copy link
Contributor

OpenID4VP has a (small) section on how the Wallet shall be launched/invoked/started.
At least copying the section would not seem like a bad idea to me.

Especially section at https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-4.1-1

The Credential Issuer sends Credential Offer using an HTTP GET request or an HTTP redirect to the Wallet's Credential Offer Endpoint defined in Section 11.1.

does not match what many wallets have implemented today. Rather referencing to a Wallet Invocation Section may be a better solution.

@peppelinux
Copy link
Member

I agree, Wallet Invocation is something very particular in this field and it worth of a dedicated section (security considerations included I would add)

@Sakurann
Copy link
Collaborator

I agree. redirect and GET are definitely not the only options. I tried clarify this in PR #246. please review and comment if it meets your expectations.

@jogu
Copy link
Contributor

jogu commented Sep 16, 2024

Some or maybe all of this is probably resolved by the fix for #13, PR #380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants