-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing the c_nonce_expires_in
parameter
#394
Comments
Concur with the removal of [1] I think that's what the cool kids say nowadays |
Now that #404 has been merged, it seem like a good time to consider doing this. I think it's just the nonce endpoint now. Would others agree? I don't think the "has-PR" label is correct BTW. |
I do and would be happy to do the PR if we have consensus. |
I think the practical outcome of removing Basically the "well I don't know if this one might still be valid so I might as well get a new one before I do a bunch of potentially 'expensive' generation of proofs" approach. |
If we are concerned that this sort of implementation behaviour might set in, we could always add some implementation guidance that makes it clear that a wallet should continue to use an obtained nonce until its given a new one, for instance DPoP has the following to say on this topic. "It is up to the authorization server when to supply a new nonce value for the client to use. The client is expected to use the existing supplied nonce in DPoP proofs until the server supplies a new nonce value." This won't prevent a wallet electing to use a nonce only once, however I'm not sure that is preventable even with the |
The
c_nonce_expires_in
parameter is intended to signal to the client/wallet when thec_nonce
expires and therefore when a client/wallet should obtain a new one. However, given a credential issuer can invalidate ac_nonce
at any stage this parameter is a bit of an un-reliable signal to clients/wallets. Practically this means clients/wallets will have to account for an error at the credential response endpoint due to an invalid nonce even if it isn't expired. For that reason I think we should remove thec_nonce_expires_in
parameter and therefore simplify the nonce handling.The text was updated successfully, but these errors were encountered: