Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change credential type identifier vc+sd-jwt to dc+sd-jwt #415

Merged
merged 3 commits into from
Nov 21, 2024
Merged

change credential type identifier vc+sd-jwt to dc+sd-jwt #415

merged 3 commits into from
Nov 21, 2024

Conversation

charsleysa
Copy link
Contributor

Implements #414

Sakurann
Sakurann approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this PR!!

@Sakurann
Copy link
Collaborator

@charsleysa can you please sign OIDF's IPR agreement so that we can accept contributions from you and merge this PR? thank you!

@charsleysa
Copy link
Contributor Author

@Sakurann I signed yesterday using the online docusign form, is there any other steps I need to perform?

babisRoutis
babisRoutis approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Checked also the issued credential.

@jogu jogu changed the title change media type vc+sd-jwt to dc+sd-jwt change credential type identifier vc+sd-jwt to dc+sd-jwt Nov 19, 2024
awoie
awoie approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving provided @bc-pi suggestion gets committed

@charsleysa charsleysa requested review from jogu and bc-pi November 19, 2024 20:23
@Sakurann Sakurann merged commit 910492a into openid:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babisRoutis babisRoutis babisRoutis approved these changes

@bc-pi bc-pi bc-pi approved these changes

@Sakurann Sakurann Sakurann approved these changes

@awoie awoie awoie approved these changes

@paulbastian paulbastian paulbastian approved these changes

@tplooker tplooker tplooker approved these changes

@c2bo c2bo c2bo approved these changes

@selfissued selfissued selfissued approved these changes

@jogu jogu Awaiting requested review from jogu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@charsleysa @Sakurann @jogu @selfissued @c2bo @tplooker @paulbastian @awoie @bc-pi @babisRoutis