Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change credential type identifier vc+sd-jwt to dc+sd-jwt #415

Merged
merged 3 commits into from
Nov 21, 2024
Merged

change credential type identifier vc+sd-jwt to dc+sd-jwt #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fe7eda
change media type `vc+sd-jwt` to `dc+sd-jwt`
charsleysa Nov 15, 2024
2baad58
Merge branch 'main' into change-sd-jwt-vc-media-type
charsleysa Nov 19, 2024
aaa442d
apply changes from pr review
charsleysa Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/authorization_details_sd_jwt_vc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[
{
"type": "openid_credential",
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"vct": "SD_JWT_VC_example_in_OpenID4VCI"
}
]
2 changes: 1 addition & 1 deletion examples/credential_metadata_sd_jwt_vc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"credential_configurations_supported": {
"SD_JWT_VC_example_in_OpenID4VCI": {
"format": "vc+sd-jwt",
"format": "dc+sd-jwt",
"scope": "SD_JWT_VC_example_in_OpenID4VCI",
"cryptographic_binding_methods_supported": [
"jwk"
Expand Down
6 changes: 3 additions & 3 deletions examples/credential_response_sd_jwt_vc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Cache-Control: no-store
{
"credentials": [
{
"credential": "eyJhbGciOiAiRVMyNTYiLCAidHlwIjogInZjK3NkLWp3d
"credential": "eyJhbGciOiAiRVMyNTYiLCAidHlwIjogImRjK3NkLWp3d
CIsICJraWQiOiAiZG9jLXNpZ25lci0wNS0yNS0yMDIyIn0.eyJfc2QiOiBbI
jA5dktySk1PbHlUV00wc2pwdV9wZE9CVkJRMk0xeTNLaHBINTE1blhrcFkiL
CAiMnJzakdiYUMwa3k4bVQwcEpyUGlvV1RxMF9kYXcxc1g3NnBvVWxnQ3diS
Expand All @@ -23,8 +23,8 @@ Cache-Control: no-store
mYiOiB7Imp3ayI6IHsia3R5IjogIkVDIiwgImNydiI6ICJQLTI1NiIsICJ4I
jogIlRDQUVSMTladnUzT0hGNGo0VzR2ZlNWb0hJUDFJTGlsRGxzN3ZDZUdlb
WMiLCAieSI6ICJaeGppV1diWk1RR0hWV0tWUTRoYlNJaXJzVmZ1ZWNDRTZ0N
GpUOUYySFpRIn19fQ.oiDeF5QD8nCi8NHpKCVBsyitThK1xdRPtMePDdEIqJ
FY1BKtd5PhYjXLUVg3VuQZqyuOUev0OQAgu1KuMY0DNA~WyIyR0xDNDJzS1F
GpUOUYySFpRIn19fQ.dVjA0sh4xGD32uPqc9h4WHiEL3A08kiKNE08IIrtn3
PJvljLU7n19LBTtuzPFZoc_GoPuS97SIDbz96K8pkZew~WyIyR0xDNDJzS1F
2ZUNmR2ZyeU5STjl3IiwgImdpdmVuX25hbWUiLCAiSm9obiJd~WyJlbHVWNU
9nM2dTTklJOEVZbnN4QV9BIiwgImZhbWlseV9uYW1lIiwgIkRvZSJd~WyI2S
Wo3dE0tYTVpVlBHYm9TNXRtdlZBIiwgImVtYWlsIiwgImpvaG5kb2VAZXhhb
Expand Down
9 changes: 5 additions & 4 deletions openid-4-verifiable-credential-issuance-1_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,7 @@ This section defines a Credential Format Profile for Credentials complying with

### Format Identifier

The Credential Format Identifier is `vc+sd-jwt`.
The Credential Format Identifier is `dc+sd-jwt`.

### Credential Issuer Metadata {#server-metadata-sd-jwt-vc}

Expand All @@ -2270,7 +2270,7 @@ The following additional Credential Issuer metadata parameters are defined for t
* `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier.
* `order`: OPTIONAL. An array of the claim name values that lists them in the order they should be displayed by the Wallet.

The following is a non-normative example of an object comprising the `credential_configurations_supported` parameter for Credential Format `vc+sd-jwt`.
The following is a non-normative example of an object comprising the `credential_configurations_supported` parameter for Credential Format `dc+sd-jwt`.

<{{examples/credential_metadata_sd_jwt_vc.json}}

Expand All @@ -2281,15 +2281,15 @@ The following additional claims are defined for authorization details of type `o
* `vct`: REQUIRED. String as defined in (#server-metadata-sd-jwt-vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer. It MUST only be present if the `format` claim is present. It MUST not be present otherwise.
* `claims`: OPTIONAL. Object as defined in (#server-metadata-sd-jwt-vc) excluding the `display` and `value_type` parameters. `mandatory` parameter here is used by the Wallet to indicate to the Issuer that it only accepts Credential(s) issued with those claim(s).

The following is a non-normative example of an authorization details object with Credential Format `vc+sd-jwt`.
The following is a non-normative example of an authorization details object with Credential Format `dc+sd-jwt`.

<{{examples/authorization_details_sd_jwt_vc.json}}

### Credential Response {#credential-response-jwt-vc-json}

The value of the `credential` claim in the Credential Response MUST be a string that is an SD-JWT VC. Credentials of this format are already suitable for transfer and, therefore, they need not and MUST NOT be re-encoded.

The following is a non-normative example of a Credential Response containing a Credential of format `vc+sd-jwt`.
The following is a non-normative example of a Credential Response containing a Credential of format `dc+sd-jwt`.

<{{examples/credential_response_sd_jwt_vc.txt}}

Expand Down Expand Up @@ -2571,6 +2571,7 @@ The technology described in this specification was made available from contribut
* removes `c_nonce` and `c_nonce_expires_in` from the Credential Error Response
* Fixed #239: Completed IANA Considerations section
* add key attestation as additional information in a proof of possesion and new proof type
* change credential format identifier `vc+sd-jwt` to `dc+sd-jwt` to align with the media type in draft -06 of [@I-D.ietf-oauth-sd-jwt-vc] and update `typ` accordingly in examples

-14

Expand Down