-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexibility in Verifier Attestation JWT typ parameter #343
Comments
As discussed offline - If you want to use a credential as a verifier attestation it probably makes most sense to wrap that credential as a sub-element of the attestation (not fully thought this through). Removing the requirements around typ would be contrary to the JWT BCP, https://datatracker.ietf.org/doc/rfc8725/ |
I'm not in favor of the removal of "typ" but I am in favor of updating the cited spec language from:
to
I'd be glad to create a PR achieving this goal. |
I do not think it is that straightforward. A trust mark as defined in https://openid.net/specs/openid-federation-1_0.html#section-7.1 does not meet the requirements laid out in for a verifier attestation in https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-5.10.4 (for example the 'cnf' claim is not required). It is also not immediately obvious to me why a trust mark would be a good way to authenticate a client when the client can (more easily?) be authenticated using the federation client id scheme. I think a solution has been jumped straight to without actually describing a problem that needs to be solved. We should start by agreeing what problem exists and needs to be solved. |
I agree with @jogu. I would also like to understand the problem to be solved and the concrete solution proposal. The verifier attestation method has a certain behavior and defines expectations regarding the content of the verifier attestation. And following the JWT BCP, it also defines the |
In the current Draft 22, we have the following language (here)
There might be several reasons to justify a more flexible approach, enabling any kind of typ or the absence of the typ value, due to the coexistence of multiple trust frameworks enabling multiple verifier attestation types.
I suggest the removal or the change of the previous sentence that mandates the typ value to be set to
verifier-attestation+jwt
.The text was updated successfully, but these errors were encountered: