Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Addresses as a format #206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

IP Addresses as a format #206

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c9f7dd
IP Addresses as a format
appsdesh Sep 20, 2024
117522a
RFC4001 formatting
appsdesh Sep 24, 2024
9e83bf3
Removed IPS claim from CAEP
appsdesh Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions openid-sharedsignals-framework-1_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ normative:
RFC8936:
RFC9110:
RFC9493:
RFC4001:
CAEP:
author:
-
Expand Down Expand Up @@ -386,6 +387,31 @@ Subject Identifier Format.
"assertion_id": "_8e8dc5f69a98cc4c1ff3427e5ce34606fd672f91e6"
}

~~~
{: #sub-id-ips title="Example: 'ips' Subject Identifier"}

### IP Addresses Subject Identifier Format {#sub-id-ips}

The "IP addresses" Subject Identifier Format specifies an array of IP addresses observed by the Transmitter.
Subject Identifiers of this format MUST contain the following members:

ips

> REQUIRED. The array of IP addresses of the subject as observed by the Transmitter. The value MUST be in the format of an array of strings, each one of which represents the RFC 4001 [RFC4001] string representation of an IP address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add RFC4001 as a reference. Do this at the top of the document by adding RFC4001: on line 105.



The "IP addresses" Subject Identifier Format is identified by the name
"ips".

Below is a non-normative example of Subject Identifier for the "IP addresses"
Subject Identifier Format.

~~~ json
{
"format": "ips",
"ips": ["10.29.37.75", "98.27.134.237"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ips": ["10.29.37.75", "98.27.134.237"]
"ips": ["203.0.113.75", "2001:0db8:e700:37a7:4cd4::b868"]

For IPv4 addresses, it is best practice to use allocated example IP ranges (RFC5737). We should also have an IPv6 address in the example (RFC3849).

The IPv6 example uses common shorthand with the double colon. One question is whether we should allow that or require expansion. No opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change of opinion: we should require expanded ones. @timcappalli to find official term (could be "uncompressed", "fully expanded", or "unabbreviated": https://www.ciscopress.com/articles/article.asp?p=2803866)

2024-10-08 call: loose consensus on this

}

~~~
{: #sub-id-samlassertionid title="Example: 'saml_assertion_id' Subject Identifier"}

Expand Down
Loading