Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish a test suite #20

Open
paulromano opened this issue Dec 17, 2024 · 2 comments
Open

Establish a test suite #20

paulromano opened this issue Dec 17, 2024 · 2 comments

Comments

@paulromano
Copy link
Contributor

Right now, the capabilities in this repository have no associated test suite. To ensure software quality, a test suite should be put together covering the functionality.

@pshriwise
Copy link
Contributor

We'll need to determine what metrics are used to validate the converted models. Some initial thoughts:

  • Volume calculations (maybe targeted on a cell-by-cell basis)
  • Reference calcs (eigenvalue, flux spectra)

@MicahGale
Copy link

Might I suggest MontePy as a code-to-code comparison for the test suite. ;)

@pshriwise I feel like these sort of tests draws way too large of a box around the test's scope. IMO the requirement for this tool is that:

The MCNP and OpenMC models are semantically equivalent.

I think for an integration test I would do:

  1. Run test models through tool
  2. Open original and new model in montepy and openmc (python) respectively.
  3. Run through and assert various attributes in both models are equivalent. The geometry equivalence will be the hardest as I don't know how to assert binary trees are equivalent when they are not identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants