Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling conditions are split across codebase (e.g. p2p/node for timeout) #253

Closed
Tracked by #187
akoptelov opened this issue Mar 1, 2024 · 0 comments · May be fixed by openmina/redux-rs#1
Closed
Tracked by #187

Enabling conditions are split across codebase (e.g. p2p/node for timeout) #253

akoptelov opened this issue Mar 1, 2024 · 0 comments · May be fixed by openmina/redux-rs#1

Comments

@akoptelov
Copy link
Contributor

akoptelov commented Mar 1, 2024

Currently for triggering timeouts enabling conditions are used that access current time via state.time().

That means that such enabling conditions only can be defined for the global state, and it is impossible to do that in p2p crate for p2p actions.

For example, for testing local to p2p module we need to have that timeouts available there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant