From 686e7f4fec560e2c7a2e29c429dd55899710d737 Mon Sep 17 00:00:00 2001 From: Vojtech Szocs Date: Tue, 9 Apr 2024 18:54:53 +0200 Subject: [PATCH] Address review comments --- .devcontainer/devcontainer.json | 53 ++++++++++++++++++--------------- package.json | 4 +-- 2 files changed, 31 insertions(+), 26 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index bc6a254a..d438aa83 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,26 +1,31 @@ { - "name": "Console + Dynamic Plugin", - "dockerComposeFile": "docker-compose.yml", - "service": "plugin", - "workspaceFolder": "/workspace", - "settings": {}, - "initializeCommand": ".devcontainer/init.sh", - "postCreateCommand": "yarn && eval 'oc login $OC_URL -u $OC_USER -p $OC_PASS --insecure-skip-tls-verify'", - "forwardPorts": [9000,9001], - "portsAttributes": { - "9000": { - "label": "Console", - }, - "9001": { - "label": "Plugin static files", - "onAutoForward": "silent" - } - }, - "features": {}, - "extensions": [ - "ms-azuretools.vscode-docker", - "ms-vscode.vscode-typescript-next", - "dbaeumer.vscode-eslint", - "esbenp.prettier-vscode", - ], + "name": "Console + Plugin", + "dockerComposeFile": "docker-compose.yml", + "service": "plugin", + "workspaceFolder": "/workspace", + + "initializeCommand": ".devcontainer/init.sh", + "postCreateCommand": "yarn && eval 'oc login $OC_URL -u $OC_USER -p $OC_PASS --insecure-skip-tls-verify'", + "forwardPorts": [9000, 9001], + "portsAttributes": { + "9000": { + "label": "Console" + }, + "9001": { + "label": "Plugin static files", + "onAutoForward": "silent" + } + }, + "features": {}, + "customizations": { + "vscode": { + "settings": {}, + "extensions": [ + "ms-azuretools.vscode-docker", + "ms-vscode.vscode-typescript-next", + "dbaeumer.vscode-eslint", + "esbenp.prettier-vscode" + ] + } + } } diff --git a/package.json b/package.json index b2d5e6f0..e70bc60e 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "console-plugin-template", "version": "0.0.1", - "description": "Template project for OpenShift Console dynamic plugins", + "description": "Template project for OpenShift Console plugins", "private": true, "license": "Apache-2.0", "repository": { @@ -72,7 +72,7 @@ "name": "console-plugin-template", "version": "0.0.1", "displayName": "OpenShift Console Plugin Template", - "description": "Template project for OpenShift Console dynamic plugins. Edit package.json to change this message and the plugin name.", + "description": "Template project for OpenShift Console plugins. Edit package.json to change this message and the plugin name.", "exposedModules": { "ExamplePage": "./components/ExamplePage" },