Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update vscode engine version to 1.88.1 #4199

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bk1012
Copy link
Member

@bk1012 bk1012 commented Dec 6, 2024

Types

  • Other Changes

Background or solution

Changelog

Summary by CodeRabbit

  • 新特性
    • 更新了默认的 VSCode 引擎版本,从 1.68.0 升级至 1.88.1

@opensumi opensumi bot added the 🎨 feature feature required label Dec 6, 2024
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

Walkthrough

该拉取请求对常量 DEFAULT_VSCODE_ENGINE_VERSION 进行了修改,文件路径为 packages/core-common/src/const/application.ts。版本号已从 '1.68.0' 更新为 '1.88.1'。该更改未涉及逻辑、错误处理或控制流的其他修改。

Changes

文件路径 更改摘要
packages/core-common/src/const/application.ts 常量 DEFAULT_VSCODE_ENGINE_VERSION'1.68.0' 更新为 '1.88.1'

Possibly related PRs

Suggested reviewers

  • Ricbet

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f25f515 and a780400.

📒 Files selected for processing (1)
  • packages/core-common/src/const/application.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/core-common/src/const/application.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

hacke2
hacke2 previously approved these changes Dec 6, 2024
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erha19
erha19 previously approved these changes Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.99%. Comparing base (99ba1a3) to head (a780400).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4199   +/-   ##
=======================================
  Coverage   53.99%   53.99%           
=======================================
  Files        1616     1616           
  Lines       98108    98108           
  Branches    20077    20085    +8     
=======================================
+ Hits        52972    52975    +3     
+ Misses      37498    37495    -3     
  Partials     7638     7638           
Flag Coverage Δ
jsdom 49.58% <100.00%> (+<0.01%) ⬆️
node 15.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

winjo
winjo previously approved these changes Dec 12, 2024
@bk1012 bk1012 dismissed stale reviews from winjo, erha19, and hacke2 via f25f515 December 12, 2024 08:27
@bk1012 bk1012 force-pushed the feat/update-vscode-version-1.84.2 branch from 41c7f01 to f25f515 Compare December 12, 2024 08:27
winjo
winjo previously approved these changes Dec 12, 2024
@bk1012 bk1012 changed the title feat: update vscode engine version to 1.84.2 feat: update vscode engine version to 1.88.1 Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 feature feature required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants