Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gating model config improvements #49

Open
steffencruz opened this issue Jun 16, 2023 · 0 comments
Open

Gating model config improvements #49

steffencruz opened this issue Jun 16, 2023 · 0 comments

Comments

@steffencruz
Copy link
Contributor

Custom gating model flag is independent of gating.model_name, so people can run custom gating models without the custom flag which at a minimum disrupts the wandb tagging.

  • The custom flag should be triggered based on whether gating.model_name == __DEFAULT_GATING_MODEL_NAME__ or something similar.
  • Resync should be pushed down to the base class as it's identical in both subclasses
  • Logic of creating SentenceEmbedGatingModel vs GatingModel is also brittle. We default to GatingModel for any other gating.model_name if the custom flag is not set, which will almost certainly break with other models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant