You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Custom gating model flag is independent of gating.model_name, so people can run custom gating models without the custom flag which at a minimum disrupts the wandb tagging.
The custom flag should be triggered based on whether gating.model_name == __DEFAULT_GATING_MODEL_NAME__ or something similar.
Resync should be pushed down to the base class as it's identical in both subclasses
Logic of creating SentenceEmbedGatingModel vs GatingModel is also brittle. We default to GatingModel for any other gating.model_name if the custom flag is not set, which will almost certainly break with other models.
The text was updated successfully, but these errors were encountered:
Custom gating model flag is independent of
gating.model_name
, so people can run custom gating models without the custom flag which at a minimum disrupts the wandb tagging.gating.model_name == __DEFAULT_GATING_MODEL_NAME__
or something similar.Resync
should be pushed down to the base class as it's identical in both subclassesSentenceEmbedGatingModel
vsGatingModel
is also brittle. We default toGatingModel
for any othergating.model_name
if the custom flag is not set, which will almost certainly break with other models.The text was updated successfully, but these errors were encountered: