From 94b121b78cce371e1fb8598c99168e236da2e860 Mon Sep 17 00:00:00 2001 From: Sai Ranjit Tummalapalli Date: Thu, 30 Jan 2025 03:08:04 +0530 Subject: [PATCH] fix: scan options in react native (#29) --- packages/askar-react-native/cpp/askar.cpp | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/askar-react-native/cpp/askar.cpp b/packages/askar-react-native/cpp/askar.cpp index 894581e..f934a59 100644 --- a/packages/askar-react-native/cpp/askar.cpp +++ b/packages/askar-react-native/cpp/askar.cpp @@ -238,10 +238,10 @@ jsi::Value storeRekey(jsi::Runtime &rt, jsi::Object options) { State *state = new State(&cb); state->rt = &rt; - ErrorCode code = askar_store_rekey(storeHandle, - keyMethod.length() ? keyMethod.c_str() : nullptr, + ErrorCode code = askar_store_rekey(storeHandle, + keyMethod.length() ? keyMethod.c_str() : nullptr, passKey.c_str(), callback, CallbackId(state)); - + return createReturnValue(rt, code, nullptr); } @@ -350,7 +350,7 @@ jsi::Value sessionFetchAll(jsi::Runtime &rt, jsi::Object options) { state->rt = &rt; ErrorCode code = askar_session_fetch_all( - sessionHandle, + sessionHandle, category.c_str(), tagFilter.length() ? tagFilter.c_str() : nullptr, limit, @@ -518,7 +518,7 @@ jsi::Value sessionUpdateKey(jsi::Runtime &rt, jsi::Object options) { jsi::Value scanStart(jsi::Runtime &rt, jsi::Object options) { auto storeHandle = jsiToValue(rt, options, "storeHandle"); - auto category = jsiToValue(rt, options, "category"); + auto category = jsiToValue(rt, options, "category", true); auto tagFilter = jsiToValue(rt, options, "tagFilter", true); auto profile = jsiToValue(rt, options, "profile", true); @@ -532,12 +532,12 @@ jsi::Value scanStart(jsi::Runtime &rt, jsi::Object options) { state->rt = &rt; ErrorCode code = askar_scan_start( - storeHandle, + storeHandle, profile.length() ? profile.c_str() : nullptr, - category.c_str(), + category.length() ? category.c_str() : nullptr, tagFilter.length() ? tagFilter.c_str() : nullptr, - offset, - limit, + offset, + limit, orderBy.length() ? orderBy.c_str() : nullptr, descending, callbackWithResponse, @@ -636,9 +636,9 @@ jsi::Value keyGenerate(jsi::Runtime &rt, jsi::Object options) { LocalKeyHandle out; ErrorCode code = askar_key_generate( - algorithm.c_str(), - keyBackend.length() ? keyBackend.c_str() : nullptr, - ephemeral, + algorithm.c_str(), + keyBackend.length() ? keyBackend.c_str() : nullptr, + ephemeral, &out );