atftpd: update init script to use procd and publish service #23765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please split this up in two commits.
Then we could better port the procd init change to the other stable branches if we want. We should make the mdns handling configurable, just like we do with the dropbear. Not everyone wants to have mdns. |
mhusaam
force-pushed
the
for_atftpd_mdns
branch
from
f1b0bd7
to
7592979
Compare
|
Thank you for reviewing, your comments have been addressed. @feckert, kindly check again. |
feckert
requested changes
Apr 8, 2024
* update init script to use procd Signed-off-by: Mohd Husaam Mehdi <[email protected]>
mhusaam
force-pushed
the
for_atftpd_mdns
branch
from
7592979
to
95adb0a
Compare
|
Please also bump the PKG_RELEASE number. Then we can merge it. |
update init script to announce tftp service over mdns Signed-off-by: Mohd Husaam Mehdi <[email protected]>
mhusaam
force-pushed
the
for_atftpd_mdns
branch
from
95adb0a
to
19e38ac
Compare
|
updated, kindly review |
|
Thanks merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohd Husaam Mehdi [email protected]