[#58160] fix existing sort helper specs

opf · Dec 10, 2024 · 1f25d4e · 1f25d4e
1 parent 80bd36d
commit 1f25d4e
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/spec/helpers/sort_helper_spec.rb b/spec/helpers/sort_helper_spec.rb
@@ -281,11 +281,7 @@ def session; @session ||= {}; end
   end
 
   describe "#sort_header_with_action_menu" do
-    subject(:output) do
-      helper.sort_header_with_action_menu("id",
-                                          %w[name id description], {}, **options)
-    end
-
+    let(:column) { Queries::Projects::Selects::Default.new "id" }
     let(:options) { { param: :json, sortable: true } }
     let(:sort_criteria) { SortHelper::SortCriteria.new }
 
@@ -295,6 +291,11 @@ def session; @session ||= {}; end
       Nokogiri::HTML(output).at_css("th .generic-table--sort-header action-menu")
     end
 
+    subject(:output) do
+      helper.sort_header_with_action_menu(column,
+                                          %w[name id description], {}, **options)
+    end
+
     before do
       # helper relies on this instance var
       @sort_criteria = sort_criteria
@@ -343,7 +344,7 @@ def session; @session ||= {}; end
 
     context "with the current column being the leftmost one" do
       subject(:output) do
-        helper.sort_header_with_action_menu("id",
+        helper.sort_header_with_action_menu(column,
                                             %w[id name description], {}, **options)
       end
 
@@ -359,7 +360,7 @@ def session; @session ||= {}; end
 
     context "with the current column being the rightmost one" do
       subject(:output) do
-        helper.sort_header_with_action_menu("id",
+        helper.sort_header_with_action_menu(column,
                                             %w[name description id], {}, **options)
       end
 
@@ -397,7 +398,7 @@ def session; @session ||= {}; end
 
     context "with a filter mapping for the column" do
       subject(:output) do
-        helper.sort_header_with_action_menu("id",
+        helper.sort_header_with_action_menu(column,
                                             %w[name id description], { "id" => "id_code" }, **options)
       end
 
@@ -413,7 +414,7 @@ def session; @session ||= {}; end
     context "with the filter mapping specifying there is no filter for the column" do
       subject(:output) do
         # With the filter name mapped to nil, we expect no filter action to be present.
-        helper.sort_header_with_action_menu("id",
+        helper.sort_header_with_action_menu(column,
                                             %w[name id description], { "id" => nil }, **options)
       end