Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talkback reads 14 underscore in a question in What is a ratio chapter #5381

Open
KolliAnitha opened this issue Dec 12, 2022 · 9 comments · May be fixed by #5553
Open

Talkback reads 14 underscore in a question in What is a ratio chapter #5381

KolliAnitha opened this issue Dec 12, 2022 · 9 comments · May be fixed by #5553
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@KolliAnitha
Copy link

KolliAnitha commented Dec 12, 2022

Describe the bug
Talkback reads 14 underscore in a question in What is a ratio chapter

To Reproduce
Steps to reproduce the behavior:
Pre- requisite: Enable Talkback

  1. Go to 'Ratios and Proportions'
  2. Click on 'What is Ratio'
  3. Click on Continue till you reach to page 'James turned the page and saw a recipe for banana smoothie.'
  4. See error

Actual behavior:
Talkback is reading 14 underscores. This might be a bit difficult for users to understand that it is a blank left for a question

Demonstration
Screenshot_2022-12-12-15-39-57-27_943a62cb4c6fb83e010e1c2e82766a17

Device/emulator being used: One plus nord2 5g
Android or SDK version (e.g. Android 5 or SDK 21): Android version 12
App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-beta-5e64fae55e

@BenHenning
Copy link
Member

Is this also an issue with ChromeVox or other web screenreaders for Oppia web @KolliAnitha?

@KolliAnitha
Copy link
Author

@BenHenning, Chromevox also reads 'We’ll need to mix milk and banana puree in the ratio 14 underscores.'

@BenHenning
Copy link
Member

Thanks @KolliAnitha.

This seems like a content issue that needs to be addressed, then. Sending over to the content team to figure out how they want to handle this.

@seanlip seanlip added the bug End user-perceivable behaviors which are not desirable. label Mar 29, 2023
@seanlip seanlip transferred this issue from oppia/oppia-android Jun 4, 2023
@Kebith
Copy link

Kebith commented Mar 25, 2024

Confirming from the lesson review team that this issue has been fixed.

@Kebith Kebith closed this as completed Mar 25, 2024
@seanlip
Copy link
Member

seanlip commented Mar 27, 2024

@Kebith Just wanted to double-check this one -- could you please confirm how Talkback currently reads the sentence? Thanks!

@seanlip seanlip reopened this Mar 27, 2024
@Kebith
Copy link

Kebith commented Mar 27, 2024

@seanlip
Reads as "We'll need to mix milk and banana puree in the ratio (silence).

Can you complete..."

@seanlip
Copy link
Member

seanlip commented Mar 28, 2024

Thanks @Kebith! Just to double-check, are you listening to the voiceovers, or to Talkback?

Voiceovers are human-created recordings of the content in the app, but Talkback refers to functionality on the app specifically for e.g. screenreader users (and it has to be enabled through the Accessibility menu). So just wanted to make sure we're looking at the right thing here before closing it.

@Kebith
Copy link

Kebith commented Mar 28, 2024

Oh! I was listening to the voiceovers, not talkback. Sorry!

Not sure I know how to access the talkback.

@seanlip
Copy link
Member

seanlip commented Mar 28, 2024

Ah ok, thanks! I'll discuss it with @BenHenning when we meet next.

@seanlip
Copy link
Member

seanlip commented Apr 10, 2024

Discussed with @BenHenning -- let's treat "2+ underscores, with space/punctuation on both sides" as a single token for speech purposes, and read it as "blank". This representation should be generated as part of the Android data import pipeline, so moving this issue back to the Android repo.

@seanlip seanlip transferred this issue from oppia/lessons-team Apr 10, 2024
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels May 17, 2024
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@subhajitxyz subhajitxyz self-assigned this Oct 11, 2024
@Nik-09
Copy link
Member

Nik-09 commented Oct 29, 2024

2+ underscores, with space/punctuation on both sides

@seanlip Can you please help me to understand the rationale behind 2+ underscores? If the lessons contain only '__' (two underscores) between words, how do we want the voiceover to say this?

This is important for understanding the requirements for designing the Automatic voiceover project.

Thank you

@seanlip
Copy link
Member

seanlip commented Oct 30, 2024

@Nik-09 I think we would still say "blank" in that case. Only for a single underscore would we say "underscore".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
7 participants