MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186

adhiamboperes · 2023-10-12T20:35:41Z

Description

We would like to fix all the remaining lint issues on Oppia Android in the "MissingDefaultResource + AppCompatCustomView + FragmentTagUsage" category.

Steps To Reproduce

Run the following command from a terminal in a checked-out Oppia Android repo:

./gradlew :app:lint

Output:

MissingDefaultResource mainly has a single issue with a string which has different names in english and other translations. It can be easily fixed, by matching the name of that string in english and other translations.
For AppCompatCustomView, it can be fixed by replacing the Normal views with AppCompat views
tags can be replaced with <androidx.fragment.app.FragmentContainerView/>.

Expected Behavior

Running the command above should not show any errors.

The text was updated successfully, but these errors were encountered:

sichchurov · 2023-10-15T15:29:05Z

./gradlew :app:lint
This command is always finished with failed

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.8/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 6m 38s
155 actionable tasks: 11 executed, 144 up-to-date

@adhiamboperes I have resolved the FragmentTagUsage issue
here is a lint report screenshot before

and after

theMr17 · 2023-10-16T11:47:01Z

Hi @sichchurov, Please look into those issues which are not assigned to anyone.

…gUsage (#5191)  ## Explanation  Fixes #5186 [part of #5169] 1. `MissingDefaultResource` has been fixed already by #5172. It had issues with these plurals: - [minutes_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L456) - [hours_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L461C18-L461C27) - [days_ago](https://github.com/oppia/oppia-android/blob/e060e2ff265ce35c92f1b969f6d7ad002d1a62ad/app/src/main/res/values/strings.xml#L465C18-L465C26) 3. For `AppCompatCustomView`, it is fixed by replacing the Normal views with AppCompat views 4. `<fragment/>` tags are replaced with `<androidx.fragment.app.FragmentContainerView/>`, with some changes in the NavigationDrawerFragment to ensure that binding has been initialized before it is accessed. ## Screen Recording https://github.com/oppia/oppia-android/assets/84731134/3a340cff-70a4-4e77-a1a3-e5b7a8c71a6e ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). <br> --------- Co-authored-by: Adhiambo Peres <[email protected]>

…agmentTagUsage (#5191)" This reverts commit 5075c54.

…omView + FragmentTagUsage" (#5287) Fix #5284: Reverts #5191. See issue for details. This should be a clean revert.

BenHenning · 2023-12-23T09:19:04Z

#5191 was reverted, so this is no longer fixed.

M-e-h-u-l-21 · 2024-01-19T07:51:27Z

@BenHenning ./gradlew :app:lint , this command always resulted in errors.
I've fixed the AppCompatCustomView and FragmentTagUsage issues.
This is the lint report after fixing the mentioned issues:

theMr17 · 2024-01-28T06:03:23Z

Unassigning myself, as this can be a good first issue for new contributors.

tobioyelekan · 2024-11-13T16:38:57Z

Hi @adhiamboperes new contributor here, can I pick this up?

adhiamboperes · 2024-11-15T08:41:48Z

Hi @adhiamboperes new contributor here, can I pick this up?

Hi, what's your proposed solution for this issue? Please refer to the issue thread for previously proposed solutions, and note that we had to revert a PR solving this due to some crashes.

tobioyelekan · 2024-11-19T00:51:53Z

Hi @adhiamboperes

For AppCompatCustomView -> I replaced it with AppCompat Views
For FragmentTagUsage, I followed a similar approach to the previous solution, but I used onViewCreated to setup the drawer, which is guaranteed to be called after the binding is initialized in onCreateView().

More details:
I also placed a breakpoint to ensure the desired order:
onAttach()->setupDrawer()->onCreateView()->onViewCreated()

This solution worked, but I noticed an issue when I minimized and returned to the app, the drawer stopped working, which I believe is because when handleOnRestart() is called, it re-initializes the drawer fragment and calls setUpDrawer() again. At this point, I believe the fragment is not recreated thereby not calling onCreate() and onViewCreated(), I believe this should be set once, and will be called again when the activity is destroyed. I temporarily removed the handleOnRestart() and everything seems to be working fine.

Please let me know what you think, I look forward to your response @adhiamboperes

adhiamboperes · 2024-11-20T11:07:57Z

@tobioyelekan, please feel free to create a PR for this. At the same time, does removing thehandleOnRestart() call remove any required re-initializations? Please ensure that the app works the same way before and after the fix.

tobioyelekan · 2024-11-25T02:33:42Z

@adhiamboperes so far, there's no additional re-initializations, PR ready for review #5582

## Explanation Fixes [#5168](#5186) 1. For `AppCompatCustomView`, replaced it with AppCompat Views 2. For `FragmentTagUsage`, replaced `<fragment/>` with <androidx.fragment.app.FragmentContainerView/>. Made some changes to `NavigationDrawerFragment` to: - ensured `setUpDrawer()` is called first to initialize the `drawerLayout`, `toolbar` and `menuItemId` - followed by `onCreateView()` ensuring to bind the fragment - followed on `onViewCreated()` to setup drawer functions/listeners 3. Faced an issue similar to [drawer not working](#5266), by minimising and resuming the app, (the drawer button stopped working). - Fixed this by removing `onRestart()` from respective Activies making a call to `setUpNavigationDrawer()` which at that point is not necessary, since the fragment has been inflated initially, and would be re-inflated if the fragment is recreated. 4. Also tested this [bug](#5284) following the steps to reproduce. No issues encountered **Lint report (Before):** ![Screenshot 2024-11-24 at 6 11 50 AM](https://github.com/user-attachments/assets/479da7e9-ea3d-47d5-9c69-ff5c97992750) **Lint report (After):** ![Screenshot 2024-11-24 at 8 06 27 AM](https://github.com/user-attachments/assets/68ef6cb9-b9b6-45ac-a901-ed64540ee674) ## Screen Record https://github.com/user-attachments/assets/6db98657-d470-4263-a5ac-d055f4d64e66 ## Essential Checklist  - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

adhiamboperes mentioned this issue Oct 12, 2023

[BUG]: Fix all Android lint failures. #5169

Open

25 tasks

theMr17 self-assigned this Oct 13, 2023

theMr17 mentioned this issue Oct 16, 2023

Fix: #5186: MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5191

Merged

6 tasks

seanlip added this to [Team] Developer Workflow & Infrastructure - Android Oct 18, 2023

github-project-automation bot moved this to Todo in [Team] Developer Workflow & Infrastructure - Android Oct 18, 2023

adhiamboperes closed this as completed in #5191 Dec 5, 2023

github-project-automation bot moved this from Todo to Done in [Team] Developer Workflow & Infrastructure - Android Dec 5, 2023

adhiamboperes added a commit that referenced this issue Dec 23, 2023

Revert "Fix: #5186: MissingDefaultResource + AppCompatCustomView + Fr…

17ebf2b

…agmentTagUsage (#5191)" This reverts commit 5075c54.

BenHenning pushed a commit that referenced this issue Dec 23, 2023

Fix #5284: Revert "Fix: #5186: MissingDefaultResource + AppCompatCust…

658c596

…omView + FragmentTagUsage" (#5287) Fix #5284: Reverts #5191. See issue for details. This should be a clean revert.

BenHenning pushed a commit that referenced this issue Dec 23, 2023

Fix #5284: Revert "Fix: #5186: MissingDefaultResource + AppCompatCust…

cf3fc36

…omView + FragmentTagUsage" (#5287) Fix #5284: Reverts #5191. See issue for details. This should be a clean revert.

BenHenning reopened this Dec 23, 2023

github-project-automation bot moved this from Done to In Progress in [Team] Developer Workflow & Infrastructure - Android Dec 23, 2023

theMr17 removed their assignment Jan 28, 2024

adhiamboperes assigned tobioyelekan Nov 20, 2024

tobioyelekan mentioned this issue Nov 25, 2024

Fix #5168: appcompat custom view fragment tag usage lint error #5582

Merged

6 tasks

adhiamboperes closed this as completed in #5582 Dec 5, 2024

adhiamboperes added this to the 0.14 Release Blockers (Beta "Early Access") milestone Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186

MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186

adhiamboperes commented Oct 12, 2023 •

edited

Loading

sichchurov commented Oct 15, 2023 •

edited

Loading

theMr17 commented Oct 16, 2023

BenHenning commented Dec 23, 2023

M-e-h-u-l-21 commented Jan 19, 2024

theMr17 commented Jan 28, 2024

tobioyelekan commented Nov 13, 2024 •

edited

Loading

adhiamboperes commented Nov 15, 2024 •

edited

Loading

tobioyelekan commented Nov 19, 2024

adhiamboperes commented Nov 20, 2024

tobioyelekan commented Nov 25, 2024

MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186

MissingDefaultResource + AppCompatCustomView + FragmentTagUsage #5186

Comments

adhiamboperes commented Oct 12, 2023 • edited Loading

Description

Steps To Reproduce

Expected Behavior

sichchurov commented Oct 15, 2023 • edited Loading

theMr17 commented Oct 16, 2023

BenHenning commented Dec 23, 2023

M-e-h-u-l-21 commented Jan 19, 2024

theMr17 commented Jan 28, 2024

tobioyelekan commented Nov 13, 2024 • edited Loading

adhiamboperes commented Nov 15, 2024 • edited Loading

tobioyelekan commented Nov 19, 2024

adhiamboperes commented Nov 20, 2024

tobioyelekan commented Nov 25, 2024

adhiamboperes commented Oct 12, 2023 •

edited

Loading

sichchurov commented Oct 15, 2023 •

edited

Loading

tobioyelekan commented Nov 13, 2024 •

edited

Loading

adhiamboperes commented Nov 15, 2024 •

edited

Loading