Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even when the message format is incorrect, it still assigns a reviewer #322

Open
shricodev opened this issue Jun 3, 2023 · 2 comments
Open

Comments

@shricodev
Copy link

Describe the bug

As per the PR Pointer second bullet:

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.

Even when the message format is wrong it assigns the reviewer.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any PR thread and write a message as such "PTAL smthng smthng @mention, smthng".
  2. This should assign the @mentioned guy to the PR.

Observed behavior
I have faced this error sometimes. oppia/oppia#18224 (comment)

Expected behavior
This reviewer assignment should be appropriately done with an exact match of the format else in such a conversation it will add the reviewer mistakenly.

Additional context
It seems to be on the lookout for the term PTAL anywhere in the sentence and for any instances where the same sentence contains a @mention along with some additional word, It assigns the @mention. However, this needs to be checked once manually.

@gp201
Copy link
Member

gp201 commented Jul 2, 2023

@shricodev If you leave a comment in the following format PTAL smthng smthng @mention, smthng., it will not assign a reviewer since it does not follow the following format {{Question/comment}} @{{reviewer_username}} PTAL

@shricodev
Copy link
Author

Hello, @gp201, would you kindly consider taking a look at the oppiabot assignment below this comment? Thanks

I have faced this error sometimes. oppia/oppia#18224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants