-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part Of #133: Update Dependencies #269
Conversation
@jameesjohn @vojtechjelinek I updated the description with logs related to left dependencies, will prefer to cover them in separate PRs.Also please shed some light on usage on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great! Just to check did you verify that there are no breaking changes and can you also do testing with your personal repo of some basic Oppiabot features.
Also, this should probably be "Fix part of #133" since we need to also migrate the three remaining libraries.
@vojtechjelinek @jameesjohn did some testing here mridul-netizen/oppia-bot-test-repo-#12 any specific job you'd like to mention I should test? Other than that I think it's working fine. |
I think if the tests pass, you should be fine. |
Since this is a dev dependency, I think it's fine. Although I'm not sure changing it to @vercel/ncc would change the workings of the package since they just changed organizations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. Otherwise, LGTM!
"newrelic": "^6.6.0", | ||
"axios": "^0.21.1", | ||
"dotenv": "^9.0.2", | ||
"google-auth-library": "^7.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should manually test the CLA features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/mridul-netizen/oppia-bot-test-repo-/runs/2777213618?check_suite_focus=true in case the user has not signed the CLA the test fails!
Unassigning @jameesjohn since the review is done. |
Hi @mridul-netizen, it looks like some changes were requested on this pull request by @jameesjohn. PTAL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Unassigning @vojtechjelinek since they have already approved the PR. |
@jameesjohn PTAL |
Unassigning @mridul-netizen since a re-review was requested. @mridul-netizen, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unassigning @jameesjohn since they have already approved the PR. |
Hi @mridul-netizen, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Following dependencies are left to update
1.Got this while updating
@zeit/ncc
but I updated it to the last latest release@zeit/ncc is no longer maintained. Please use @vercel/ncc instead.
2.While updating
@actions/github
1.
Object.setPrototypeOf called on null or undefined
2.
TypeError: GitHub is not a constructor
3.While updating
probot
most comon error was"schedule.repository" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)
Explanation
This PR fixes part of #133
Checklist