-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When sending "stale review" notifications, create separate threads on GitHub Discussions. #4
Comments
@seanlip I would like to work on this issue to check the feasibility of all the points you mentioned and work on them. Thanks! |
Thanks @SD-13, assigned you! |
@seanlip If we delete all old threads (including "open" threads), how we are going to monitor stalling reviews? |
Deletion of all threads is only done just before we populate that category with new threads. This way, the category will only contain the latest stale review threads. |
Okay. Then we will be able to monitor stale reviews till new threads are created. |
This is working in my test repo with one issue, sometimes it is not deleting last few discussions and I am looking into that. |
Can't reproduce the issue anymore https://jam.dev/c/c9a2c136-9b90-4a6e-bf47-bb6ee4accbef |
Currently, all our "pending review" notifications go into a single thread on GitHub Discussions. This makes it hard to keep track of pending reviews, because we cannot easily mark a message as resolved or see which of them are still open, It is also a bit difficult for reviewers to find the latest thread that they are supposed to look at.
Instead, it would be nice if the stale review notifier did the following each time it ran:
This would have the following effects:
The text was updated successfully, but these errors were encountered: