Skip to content

Commit 0800b3c

Browse files
committed
Lint test files
1 parent b947326 commit 0800b3c

File tree

6 files changed

+20
-9
lines changed

6 files changed

+20
-9
lines changed

test/blobDMLBindAsBuffer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ var should = require('should');
3232
var async = require('async');
3333
var dbConfig = require('./dbconfig.js');
3434
var random = require('./random.js');
35-
var fs = require('fs');
3635
var assist = require('./dataTypeAssist.js');
3736

3837
describe('82.blobDMLBindAsBuffer.js', function() {

test/clobDMLBindAsString.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
var oracledb = require('oracledb');
3131
var should = require('should');
3232
var async = require('async');
33-
var fs = require('fs');
3433
var dbConfig = require('./dbconfig.js');
3534
var random = require('./random.js');
3635

test/cqn01.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ describe('224. cqn01.js', function() {
138138
eventEmitter.on("received", function() {
139139
console.log("Received message!");
140140
clearTimeout(timeout);
141-
resolve()
141+
resolve();
142142
});
143143
});
144144

@@ -206,7 +206,7 @@ describe('224. cqn01.js', function() {
206206
eventEmitter.on("received", function() {
207207
console.log("Received message!");
208208
clearTimeout(timeout);
209-
resolve()
209+
resolve();
210210
});
211211
});
212212

test/dbType01.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('226. dbType01.js', function() {
3535
const default_stmtCacheSize = oracledb.stmtCacheSize;
3636

3737
before(async () => {
38-
oracledb.stmtCacheSize = 0;
38+
oracledb.stmtCacheSize = 0;
3939
try {
4040
conn = await oracledb.getConnection(dbconfig);
4141
} catch (err) {
@@ -147,7 +147,7 @@ describe('226. dbType01.js', function() {
147147

148148
it('226.9 DB_TYPE_NUMBER', async () => {
149149
try {
150-
const sql = `SELECT DUMP(:1) FROM dual`;
150+
const sql = `SELECT DUMP(:1) FROM dual`;
151151
const result = await conn.execute(sql,
152152
[{ val: numInVal, type: oracledb.DB_TYPE_NUMBER }]);
153153
(result.rows[0][0]).should.startWith('Typ=2 Len=2');

test/list.txt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1289,6 +1289,13 @@ Overview of node-oracledb functional tests
12891289
72.2.4 Negative - not providing first parameter
12901290
72.2.5 promise test of createLob()
12911291
72.2.6 call lob.close() multiple times sequentially
1292+
72.3 NCLOB
1293+
72.3.1 BIND_IN, DML, a txt file
1294+
72.3.2 BIND_IN, PL/SQL, a txt file
1295+
72.3.3 Negative - invalid type
1296+
72.3.4 Negative - invalid value
1297+
72.3.5 DML - UPDATE statement
1298+
72.3.6 BIND_INOUT, PL/SQL, IN LOB gets closed automatically
12921299

12931300
73. poolPing.js
12941301
73.1 the default value of poolPingInterval is 60

test/lobBind2.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -945,6 +945,7 @@ describe("72. lobBind2.js", function() {
945945

946946
lob.on("error", function(err) {
947947
should.not.exist(err, "lob.on 'error' event.");
948+
reject(err);
948949
});
949950

950951
lob.on("end", function() {
@@ -982,13 +983,14 @@ describe("72. lobBind2.js", function() {
982983

983984
lob.on("error", function(err) {
984985
should.not.exist(err, "lob.on 'error' event.");
986+
reject(err);
985987
});
986988

987989
lob.on("finish", async function() {
988990
const sql = `insert into nodb_tab_nclob72 (id, content)
989991
values (:id, :bindvar)`;
990992
const result = await connection.execute(sql,
991-
{ id: seq, bindvar: lob});
993+
{ id: seq, bindvar: lob});
992994
should.strictEqual(result.rowsAffected, 1);
993995
await lob.close();
994996
}); // finish event
@@ -1035,6 +1037,7 @@ describe("72. lobBind2.js", function() {
10351037

10361038
lob.on("error", function(err) {
10371039
should.not.exist(err, "lob.on 'error' event.");
1040+
reject(err);
10381041
});
10391042

10401043
lob.on("finish", async function() {
@@ -1108,13 +1111,14 @@ describe("72. lobBind2.js", function() {
11081111

11091112
lob.on("error", function(err) {
11101113
should.not.exist(err, "lob.on 'error' event.");
1114+
reject(err);
11111115
});
11121116

11131117
lob.on("finish", async function() {
11141118
const sql = `update nodb_tab_nclob72 set content = :bindvar
11151119
where id = :id`;
11161120
const result = await connection.execute(sql,
1117-
{ id: seq, bindvar: lob});
1121+
{ id: seq, bindvar: lob});
11181122
should.strictEqual(result.rowsAffected, 1);
11191123
await lob.close();
11201124
await connection.commit();
@@ -1159,14 +1163,15 @@ describe("72. lobBind2.js", function() {
11591163

11601164
lob.on("error", function(err) {
11611165
should.not.exist(err, "lob.on 'error' event.");
1166+
reject(err);
11621167
});
11631168

11641169
lob.on("finish", async function() {
11651170
const sql = `begin nodb_proc_nclob_inout1(:id, :io); end;`;
11661171
const binds = {
11671172
id: seq,
11681173
io: { type: oracledb.DB_TYPE_NCLOB,
1169-
dir: oracledb.BIND_INOUT, val: lob }
1174+
dir: oracledb.BIND_INOUT, val: lob }
11701175
};
11711176
const options = { autoCommit: true };
11721177
const result = await connection.execute(sql, binds, options);
@@ -1183,6 +1188,7 @@ describe("72. lobBind2.js", function() {
11831188

11841189
lobout.on("error", function(err) {
11851190
should.not.exist(err, "lob.on 'error' event.");
1191+
reject(err);
11861192
});
11871193

11881194
lobout.on("end", async function() {

0 commit comments

Comments
 (0)