Can't Filter By Folder With New Ruleset System #141706
Replies: 2 comments
-
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
Have you found this behaviour to change with the new rulesets? As far as I've seen that was actually how it worked with branch protection as well - essentially, it requires the checks to run, but in a GHA workflow if it's skipped due to the paths not matching it never runs (and therefore never passes). I've gotten around this when required by using an action within the actual workflow that checks what's changed and only runs steps/jobs when required - functionally the same thing except that with this approach you can return a success if the path isn't changed, and therefore pass the check and unblock the PR. https://github.com/dorny/paths-filter is the one I've used, but there are others as well. Mind you, this doesn't negate the FR because I'd love it see it be smart enough to not need this! But just a potential workaround in the meantime. |
Beta Was this translation helpful? Give feedback.
-
Select Topic Area
Product Feedback
Body
This is how we specify status checks with the new ruleset system:
But, I don't want to run the backend script when there are only frontend changes and vice versa. Normally, I would stop the script from running when there are no changes to the folder with this filter:
But, my experience has been that the status checks don't pass because the ruleset requires both. The ruleset needs to be smart enough that if nothing has changed, it's not required. This is eating up minutes.
Beta Was this translation helpful? Give feedback.
All reactions