group middlewares

[PandaWorker]

How can midwar be grouped so that the types don't break? I have a case where several routes need the same midwars, and I need to group them as a plugin and use it already, rather than specifying them every time.

import { Type as t } from '@sinclair/typebox';
import { Hono } from 'hono';

import { describeRoute, openAPISpecs } from 'hono-openapi';
import {
  validator
} from 'hono-openapi/typebox';


const authHeaderDepend = validator('header', t.Object({
  'x-authorization': t.String()
}));

const remoteUserDepend = validator('header', t.Object({
  'x-remote-user': t.String()
}));

const authRemoteUserPlugin = new Hono().use(authHeaderDepend, remoteUserDepend);

const command1 = new Hono().get('/1',
  describeRoute({
    tags: ['Private'],
    summary: 'Get command'
  }),
  authHeaderDepend,
  remoteUserDepend,
  // ... too many middlewares
  async (c) => {
    const {"x-remote-user": xRemoteUser} = c.req.valid('header');
    return c.json({ command: '1', xRemoteUser});
  }
);


const command2 = new Hono().get('/2',
  describeRoute({
    tags: ['Private'],
    summary: 'Get command 2'
  }),
   authHeaderDepend,
  remoteUserDepend,
  // ... too many middlewares
  
  async (c) => {
    return c.json({ command: '2' });
  }
);

[RWOverdijk]

Do you mean that this breaks validator types in the handler? If so, I have the same issue:

import { validator } from 'hono-openapi/valibot';
import { every } from 'hono/combine';

router.post('/', validator('json', CreateAuthorSchema), async (c) => {
  return c.json(create('authors', c.req.valid('json')), 201);
});

Works great. c.req.valid knows about json.

However this doesn't work:

import { validator } from 'hono-openapi/valibot';
import { every } from 'hono/combine';

router.post('/', every(validator('json', CreateAuthorSchema)), async (c) => {
  return c.json(create('authors', c.req.valid('json')), 201);
});

I know this is a weird place to use every. I have more, I just use this as a minimal example.

[RWOverdijk]

I've tried looking at the code to figure out what this even does, and I think that in my specific case it's much harder to begin with. The validator assigns data it needs to itself (its own middleware) using a symbol. So combining does not work, at least when it comes to openapi, because one overwrites the other if you do. The closest I got is by using Object.assign on the combiner, but then only the last added validator gets used (because that's how keys work). So it's semi-relevant to this, but not entirely.

Example assign: https://github.com/rhinobase/hono-openapi/blob/main/packages/core/src/route.ts#L75-L83

Sorry for the noise on this discussion.