Some suggestions

[Mister-Hope]

1. Add algolia search.

   Just apply it here The default search box only index headings.

2. Darkmode support is a cool feature, but it is not documented.😪(Could you check if you miss document other features as well?)

3. Setting class to body may cause side effects. So I suggest setting the dark theme with waline-dark attribute by default. So it will have no side effects.. Also mathml sould have similar change too

   At meantime, add a option called autoDark in @waline/client. Inject these below only when it's set to true.

   

4. Only few visitors on web have their own websites. So I think changing the meta default from ['nick', 'mail', 'link'] to ['nick', 'mail'] would be better (It's also something I want to report to valine). Some of the users do confuse about it when they see the comment box for the first time.

5. I would like to rewrite the style system using css variables to make it more configuable.

   like this, but all with waline- prefix
   

   If you think it's ok, are you familiar with sass? I realy want to rewrite with a css framework. (I saw your profile, you said you are a frontend developer) Nesting the selectors would be much more better to read than this:

   @media screen and (max-width: 720px) {
     .v[data-class='v'] .vcards .vcard .vimg {
       width: 2.5em;
       height: 2.5em;
     }
   }
   
   .v[data-class='v'] .vcards .vcard .vhead {
     line-height: 1.5;
     margin-top: 0;
   }
   
   .v[data-class='v'] .vcards .vcard .vhead .vnick {
     position: relative;
     font-size: 0.875em;
     font-weight: 500;
     margin-right: 0.875em;
     cursor: pointer;
     text-decoration: none;
     display: inline-block;
   }
   
   .v[data-class='v'] .vcards .vcard .vhead .vnick:hover {
     color: #d7191a;
   }
   
   .v[data-class='v'] .vcards .vcard .vhead .vmark {
     font-size: 0.775em;
     margin-right: 0.875em;
     cursor: pointer;
     text-decoration: none;
     display: inline-block;
     background: #2196f3;
     border-radius: 3px;
     color: #fff;
     padding: 0 0.3em;
   }

[Mister-Hope]

Also I saw you getting trouble with changelog after publish. Is the changelog been commited on a machine with deps installed? husky and lint-staged shall correct it if it's manually commited. @lizheming

If the commit is made by a action and it can not trigger git hooks, I can exclude it from linter. Just call me if you need that.

[lizheming]

Oh~ It's my mistake. I have not reinstall deps after git pull. I'll check it next commit, thank you for your hint again.

[lizheming]

1. OK, I have applied algolia doc search token.
2. some discussions relate with dark mode: css 問題 #110 【建议】新增一个配置 auto-colorscheme #164
3. Stylesheet in waline is also migrated from valine. I think .dark and .night selector name just want to adapter for most of themes. If the theme use .dark or .night selector to acitve dark mode, waline/valine will auto switch to it. If you think selector inject to body element has huge effect, you can just add theme into waline root element.
   Maybe we can expose options to let user define dark mode prefix selector?
4. I have not great reaction about meta default value. But I think three columns style is more beautiful than two columns. Maybe we can change default placeholder like website(optional) to hint commenter?
5. CSS variable is very awesome! I'd like to see it in your pr. And Sass is also ok, the only one we should notice is please install dart-sass to add sass support.

[Mister-Hope]

3 is cool. I can implement that. It's easy after a refactor with css styles.
And I know 5, node-sass is desperated for quite a long time, and building it is horrible in china due to network. I even wrote a gulp plugin because of it.🙄

[Mister-Hope]

And your opinion on 4 is better. But I will try to improve two comlumn style while refactoring

[lizheming]

@Mister-Hope OK, if two columns style is great I thought it's also no problem~

[Mister-Hope]

What's your opinion towards removing es3ifyPlugin?

I am going to rebuild styles after upgrading project to webpack@v5.

IE do not support css var() so it will be dropped after the style refactor. So there's no need to use es3ifyPlugin (also I am not sure if it's compatable with webapck@v5) @lizheming

[lizheming]

@Mister-Hope that is ok, just remove it.

[Mister-Hope]

Any updates with algolia?

[Mister-Hope]

All done.