Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registration & login flow form states #281

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

jonas-jonas
Copy link
Member

This PR addresses multiple issues with the navigation and overall state of the login & registration flows.

  • Allows properly navigating between steps in registration flows by adding a new "Select another method" button to the card footer
  • Fixes the "back" button, that allows the user to change their email address input
  • Addresses a few design inconsistencies
  • Exposes the current state of the form in the useOryFlow() hook

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 65.11628% with 45 lines in your changes missing coverage. Please review.

Project coverage is 59.43%. Comparing base (f172788) to head (865cebe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...react/src/theme/default/components/card/footer.tsx 16.66% 15 Missing ⚠️
...ault/components/card/current-identifier-button.tsx 72.41% 8 Missing ⚠️
...elements-react/src/components/form/form-helpers.ts 53.84% 6 Missing ⚠️
...elements-react/src/components/form/nodes/input.tsx 0.00% 4 Missing ⚠️
...ckages/elements-react/src/context/flow-context.tsx 20.00% 4 Missing ⚠️
...-react/src/theme/default/components/form/label.tsx 0.00% 4 Missing ⚠️
packages/elements-react/src/util/ui/index.ts 50.00% 2 Missing ⚠️
packages/elements-react/src/context/form-state.ts 96.55% 1 Missing ⚠️
...-react/src/theme/default/components/form/input.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   57.92%   59.43%   +1.51%     
==========================================
  Files          65       68       +3     
  Lines         820      927     +107     
  Branches      101      129      +28     
==========================================
+ Hits          475      551      +76     
- Misses        340      371      +31     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixFormState branch from b29902e to e633103 Compare November 15, 2024 11:54
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixFormState branch 2 times, most recently from 6f01bc1 to f72cea1 Compare November 18, 2024 10:08
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixFormState branch from f72cea1 to 0a8712b Compare November 18, 2024 10:12
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixFormState branch from 511d6fc to 865cebe Compare November 18, 2024 10:31
@jonas-jonas jonas-jonas merged commit a1da2ef into main Nov 18, 2024
13 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixFormState branch November 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant