Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle4XP Error creating tile in 1.4.0.7 #282

Open
nubbix opened this issue Nov 8, 2024 · 10 comments
Open

Triangle4XP Error creating tile in 1.4.0.7 #282

nubbix opened this issue Nov 8, 2024 · 10 comments

Comments

@nubbix
Copy link

nubbix commented Nov 8, 2024

Got this message today when trying to create tile +70+29
Included is the .node and .poly
zOrtho4XP_+70+029.zip

WARNING: Triangle4XP could not achieve the requested quality (min_angle), most probably due to an uncatched OSM error.
It will be tempted now with no angle constraint (i.e. min_angle=0).
Loading altitudes from DEM file.
Loading curv_tol geographic weights.
Computing curvatures from altitudes.
Constructing Delaunay triangulation by divide-and-conquer method.
Recovering segments in Delaunay triangulation.
Spreading regional attributes.
Adding Steiner points to enforce quality.
Looking for bad triangles.

ERROR: Triangle4XP really couldn't make it !

If the reason is not due to the limited amount of RAM please
file a bug including the .node and .poly files that you
will find in F:\Ortho4XP_1.4.07_win11_x86\Ortho4XP_internal\Ortho4XP_Data\Tiles\zOrtho4XP_+70+029 .

@nubbix
Copy link
Author

nubbix commented Nov 8, 2024

Also tried manual creating and hgt by Sonny, but got an error stating one need to create a mesh file for this tile which I don't know how to.

@HurricaneK5
Copy link

I'm also having this problem with tiles in Louisiana.

@aselder
Copy link

aselder commented Jan 27, 2025

Same error for +42-122. .node and .poly attached.

Data+42-122.zip

@w8sl
Copy link

w8sl commented Feb 3, 2025

Triangle4XP could not achieve the requested quality
(min_angle), most probably due to an uncatched OSM error

It will be tempted now with no angle constraint (i.e. min_angle=0)

This step completes many problematic tiles but is only functional in O4XP 1.30 and no longer in 1.40

Possible fix:

Commit: ccbc291 in #272

It is still possible to manually set "min_angle" to 0 or any value within the range of 0 to 5, as manual setting is not affected

The failure of certain tiles on Windows with a min_angle = 10 is a separate issue. The cause of this problem remains unknown at present, and it is not related to “long” integer. Different memory allocation in C ?

@nubbix
Copy link
Author

nubbix commented Feb 13, 2025

Here is an update using Bing maps in the UK

`Step 2 : Building mesh for tile +53-003 :

-> Modifying curv_tol weight map according to runway locations.
-> Modifying curv_tol weight map according to coastline location.
* Recycling OSM data from F:\Ortho4XP_1.4.07_win11_x86\Ortho4XP_internal\Ortho4XP_Data\OSM_data+50-010+53-003+53-003_coastline.osm.bz2
-> Start of the mesh algorithm Triangle4XP.
Loading altitudes from DEM file.

Loading curv_tol geographic weights.

Computing curvatures from altitudes.

Constructing Delaunay triangulation by divide-and-conquer method.

Recovering segments in Delaunay triangulation.

Spreading regional attributes.

Adding Steiner points to enforce quality.

Looking for bad triangles.

WARNING: Triangle4XP could not achieve the requested quality (min_angle), most probably due to an uncatched OSM error.
It will be tempted now with no angle constraint (i.e. min_angle=0).
Loading altitudes from DEM file.

Loading curv_tol geographic weights.

Computing curvatures from altitudes.

Constructing Delaunay triangulation by divide-and-conquer method.

Recovering segments in Delaunay triangulation.

Spreading regional attributes.

Adding Steiner points to enforce quality.

Looking for bad triangles.

ERROR: Triangle4XP really couldn't make it !

If the reason is not due to the limited amount of RAM please
file a bug including the .node and .poly files that you
will find in F:\Ortho4XP_1.4.07_win11_x86\Ortho4XP_internal\Ortho4XP_Data\Tiles\zOrtho4XP_+53-003 .


Step 2.5 : Building masks for tile +53-003 :

ERROR: Mesh file F:\Ortho4XP_1.4.07_win11_x86\Ortho4XP_internal\Ortho4XP_Data\Tiles\zOrtho4XP_+53-003\Data+53-003.mesh absent.


Step 3 : Building DSF/Imagery for tile +53-003 :

ERROR: A mesh file must first be constructed for the tile!`

If the reason is not due to the limited amount of RAM please
file a bug including the .node and .poly files that you

I cannot include these, as nothing was created for this tile

@w8sl
Copy link

w8sl commented Feb 13, 2025

It is passing on macOS with min_angle=10 ---> Mesh triangles: ---> 1,353,359
Crashing on Windows with min_angle=10

Passing on Windows (I am testing on Windows 11 ARM using x64 emulation):

min_angle=0 Mesh triangles: ---> 903,781
min_angle=5 Mesh triangles: ---> 1,107,223

Automatic run with min_angle=0 doesn't work on 1.40 but it can be set manually

Debugging the root cause of different behavior of Triangle4XP on POSIX vs Windows may be a bit complex

@nubbix
Copy link
Author

nubbix commented Feb 13, 2025

Here is the files

zOrtho4XP_+53-003.zip

@w8sl
Copy link

w8sl commented Feb 13, 2025

Thank you!
With your files, I am getting 800,556 triangles on Windows (min_angle=0), failure with min_angle=10
on macOS ARM64 and x86_64 : Mesh triangles: ---> 1,241,794 with min_angle=10

I did cross-check and swapped files generated on step 1 between macOS and Windows and get exact same results as before today - so it is definitively Triangle4XP.

  • It is not Intel vs ARM
  • The same result on Windows with "long" and "long long"
  • Inexact Volatile doesn't help.

@nubbix
Copy link
Author

nubbix commented Feb 13, 2025

I solved this using Sony's DEM Mesh for this tile. N53W003

@w8sl
Copy link

w8sl commented Feb 15, 2025

Solved, it was VS!

Triangle4XP.exe compiled with MinGW/GCC works and gives the same results on all platforms:

https://github.com/w8sl/Ortho4XP/actions/runs/13343949182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants