Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Wikimedia ignores images in categories, if there is no wikidata tag. #21873

Open
elgaard opened this issue Feb 8, 2025 · 3 comments
Assignees
Milestone

Comments

@elgaard
Copy link
Contributor

elgaard commented Feb 8, 2025

Description

It works for wikimedia_commons=File:...
But wikimedia_commons=Category:...
no longer works, unless there is a wikidata tag (and I assume that requires that wikidata references the correct Wikimedia Category but I have not tested that part).

Steps to reproduce

Find Esbjerg Strand Lystbådehavn caravan_site in OsmAnd

https://www.openstreetmap.org/way/1190666459

Press "details". Then "Online photos"

Actual result

It says "No photos available"

Expected result

Gallery of photos from Wikimedia category.

Similar to Reersø Havn Autocamperplads, https://www.openstreetmap.org/way/1311769980

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive.
Review this CAREFULLY before posting your issue!

OsmAnd Version: 4.9.7
Android version:9
Device model: SM-G950F
Crash-Logs: ?
@DmitryAlexei
Copy link
Contributor

DmitryAlexei commented Feb 10, 2025

Related

@yuriiurshuliak yuriiurshuliak added Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning and removed Nice to Have Should be fixed but there is no priority or no possibility to fix it within current horizon planning labels Feb 10, 2025
@yuriiurshuliak
Copy link

The bug can be reproduced. To verify:

  1. On the nightly or latest release version, navigate to coordinates 55.483813, 8.412003.
  2. Load the map and select the POI Esbjerg Strand Lystbådehavn caravan_site.
  3. Press Details, then Online photos.

Actual Result: You will see the "No photos available" message.

To compare, try installing OsmAnd version 4.8.6 and repeat the steps.
Expected Result: A gallery of photos from the Wikimedia category is correctly displayed.

OsmAnd~ 5.0.0#4355m, released: 2025-02-11
OsmAnd 4.8.6, released: 2024-08-08

OsmAnd~ 5.0.0#4355m OsmAnd 4.8.6

@vshcherb vshcherb changed the title Wikimedia ignores images in categories, if there is no wikidata tag. Regression: Wikimedia ignores images in categories, if there is no wikidata tag. Feb 11, 2025
@vshcherb vshcherb added this to the 5.0-android milestone Feb 11, 2025
@vshcherb vshcherb modified the milestones: 5.0-android, 5.0-web Feb 12, 2025
@vshcherb
Copy link
Member

We need to consolidate code in Android/iOS/Web via Kotlin library.

  • Tags like image, mapillary, instagram are processed locally and added to gallery displaying images

  • Tags like wikimedia_commons, wikipedia, wikidata - pass to the server to retrieve imageName, imageURL to be displayed in the Gallery

  • Web should be display identical images via POI Search web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants