Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitwise import doesn't seem to properly handle groups/transactions #46

Open
dfego opened this issue Apr 15, 2024 · 8 comments
Open

Splitwise import doesn't seem to properly handle groups/transactions #46

dfego opened this issue Apr 15, 2024 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@dfego
Copy link

dfego commented Apr 15, 2024

I've just successfully imported my data from Splitwise. I notice that it recognizes and creates my groups, but those groups don't have any transactions associated with them, and they all show as settled up. Actually, while my overall balance looks correct, I don't see any of my transactions anywhere. I will note all of my transactions are in groups.

@KMKoushik
Copy link
Member

@dfego This is intended behaviour for now. Just don't want to polute DB with 1000s of transactions, So imported only what's absolutely necessary ie) Outstanding balance and group with users. Do you think importing txs also very important?

@KMKoushik
Copy link
Member

May be I'll have explain it in the import page, so others won't get confused!

@dfego
Copy link
Author

dfego commented Apr 15, 2024

@KMKoushik for me, yes, it's essential. I only really use this with one other person, but the transaction history is important for review in determining what has been dealt with (specifically), and what hasn't, and which bucket thing is in (running ledger vs. major expenses). My use case may or may not be common though, I'm not sure.

Perhaps making it opt-in would be helpful? For my own data, I already could see all my people and the total balance, so importing that would be as trivial as me having made a single "from splitwise" transaction of the full amount. The import didn't do much for me there.

@KMKoushik KMKoushik added the enhancement New feature or request label Apr 15, 2024
@KMKoushik
Copy link
Member

@dfego Gotcha, I'll keep this as an enhancement and will try to work on it. I'll have to make sure I don't kill my DB accidentally lol.

Would you be okay if it imports upto recent 1000 expenses max? The number is arbitary, i'll come up with exact number soon!

@KMKoushik KMKoushik added this to the 1.3.0 milestone Apr 15, 2024
@dfego
Copy link
Author

dfego commented Apr 15, 2024

1000 would work for me, I've got 900+ myself. If there were some lower limit I could probably go in and coalesce things a bit, but starting with no history is a little rough! What database is this using? Are your concerns disk space or performance?

@KMKoushik
Copy link
Member

@dfego It's postgres, Not woried about space or perf of DB. Say some one have 10K txes and while processing App server may go down cuz of memory. May be I'm overthinking it and it's fine. either I have to do some stress test to be sure

@nicastelo
Copy link

@dfego It's postgres, Not woried about space or perf of DB. Say some one have 10K txes and while processing App server may go down cuz of memory. May be I'm overthinking it and it's fine. either I have to do some stress test to be sure

@KMKoushik It’s been a while, and the status of this might have changed, but I think you could just offload the work to a worker and batch the transactions?

@KMKoushik KMKoushik modified the milestones: 1.3.0, 2.0 Oct 16, 2024
@thelazyoxymoron
Copy link

Echoing the comments made by @dfego, I have a similar use-case. It is a bit confusing to see the numbers getting populated in the dashboard and not see any associated transactions.

Also, this might be a niche use-case, but I also use group expenses as a way to remember what happened during a trip. Another reason why transaction history is valuable for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants