Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate codecov/codecov-action v4 token #3862

Closed
spencerschrock opened this issue Feb 7, 2024 · 2 comments
Closed

evaluate codecov/codecov-action v4 token #3862

spencerschrock opened this issue Feb 7, 2024 · 2 comments
Labels
area/tech-debt github_actions Pull requests that update Github_actions code Stale

Comments

@spencerschrock
Copy link
Member

As of v4, a token is required for upload.
Changelog link

Some of our uploading workflows are in a pull_request trigger, which won't have access to secrets, and switching to pull_request_target just for that isn't worth the risk.

See this discussion for context: #3857 (comment)

Perhaps tokenless uploading will come back in later versions? maybe we use a different way of visualizing codecov?

Copy link

This issue has been marked stale because it has been open for 60 days with no activity.

@spencerschrock
Copy link
Member Author

One of the dependabot updates bumped it to v5 at some point, and things seem to be working.

@spencerschrock spencerschrock closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Looked at during triage meetings to Done in Scorecard - NEW Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt github_actions Pull requests that update Github_actions code Stale
Projects
Status: Done
Development

No branches or pull requests

1 participant