Arbitrary station positions (drag+drop and refactor) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starcraft66
requested changes
Sep 14, 2024
Comment on lines
+259
to
+261
| IO.puts("Transaction failed!") | ||
| IO.inspect(failed_operation) | ||
| IO.inspect(failed_value) |
There was a problem hiding this comment.
Use Logger.debug/1 here instead of directly printing out with IO.
| IO.inspect(failed_value) | ||
| socket |> put_flash(:info, "Transaction failed") | ||
| end | ||
|
|
There was a problem hiding this comment.
Please make empty colums/rows disappear from the visual designer when hitting save to reflect the state of the database and other display pages at that moment.
| @@ -17,12 +17,10 @@ defmodule Lanpartyseating.SettingsLogic do | |||
| end | |||
| end | |||
|
|
|||
| # returns an Ecto.Multi that has to be written | |||
There was a problem hiding this comment.
Wrap this in an @doc """ """ string so it can be rendered out into generated documentation
| |> Enum.into(%{}) | ||
| end | ||
|
|
||
| # {columns, rows} |
There was a problem hiding this comment.
Wrap this in an @doc """ """ string so it can be rendered out into generated documentation
| def save_station_positions(table) do | ||
| Repo.delete_all(Station) | ||
|
|
||
| def save_stations(grid) do |
There was a problem hiding this comment.
Rename this function to something more clear because it does not actually save the stations as it is written now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
columnsandrowsfrom settings, now computed from xy datais_broken) is stored instations_statusto avoid being deleted by saving settings