-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance resize #2487
Instance resize #2487
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e4582f6
to
c71671f
Compare
* Switch to regular modal * Improve modal close button alignment * Semi 'currently using:' and fix semi weight * Revert: fix semi weight Handled in #2496 instead * Switch route for modal * Disable submit if the specs are the same * Improve toast * Fix lint error `no-unused-expressions`
I did something gnarly, but luckily it seems to have worked. I pushed my own version of the omicron branch with omicron main merged in to get everything else up to date, then I bumped the API here with that commit, then I bumped omicron to main on console main, than I merged console main into here. Short version: this is pretty up to date and once resize is merged in the API we will be in good shape. This still needs a bit of polish, though. |
2113626
to
a25e107
Compare
No rush at all; just wanted to note that oxidecomputer/omicron#6774 has been merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I added that in there because you can resize from the index, at which point it might not be clear which instance you are resizing. Or at least it's helpful to reassure the user of their action. |
It seemed useful to me to have the name in the box, unless there's some other way to verify which instance they're updating. I thought putting it in the modal header (Resize instance db1) could work, but that's not a pattern we have in other places in the app. |
7b44522
to
0d4319a
Compare
Fixed the truncation. Design-wise looks good to me. |
🎉 |
oxidecomputer/console@6fe6936...059c551 * [059c5514](oxidecomputer/console@059c5514) oxidecomputer/console#2487 * [25106d32](oxidecomputer/console@25106d32) oxidecomputer/console#2581 * [653b5725](oxidecomputer/console@653b5725) oxidecomputer/console#2577 * [175d75b7](oxidecomputer/console@175d75b7) oxidecomputer/console#2575 * [3e40ff71](oxidecomputer/console@3e40ff71) oxidecomputer/console#2571 * [034ca87e](oxidecomputer/console@034ca87e) oxidecomputer/console#2567 * [4b4d7fb9](oxidecomputer/console@4b4d7fb9) oxidecomputer/console#2574 * [e116e404](oxidecomputer/console@e116e404) bump web console to latest dogfood version * [67033a32](oxidecomputer/console@67033a32) oxidecomputer/console#2566 * [c4258804](oxidecomputer/console@c4258804) oxidecomputer/console#2568 * [0f922b2e](oxidecomputer/console@0f922b2e) cleanup: move getUseApiQueries down in the file to reduce diff noise elsewhere * [cf7802a7](oxidecomputer/console@cf7802a7) oxidecomputer/console#2565
oxidecomputer/console@6fe6936...059c551 * [059c5514](oxidecomputer/console@059c5514) oxidecomputer/console#2487 * [25106d32](oxidecomputer/console@25106d32) oxidecomputer/console#2581 * [653b5725](oxidecomputer/console@653b5725) oxidecomputer/console#2577 * [175d75b7](oxidecomputer/console@175d75b7) oxidecomputer/console#2575 * [3e40ff71](oxidecomputer/console@3e40ff71) oxidecomputer/console#2571 * [034ca87e](oxidecomputer/console@034ca87e) oxidecomputer/console#2567 * [4b4d7fb9](oxidecomputer/console@4b4d7fb9) oxidecomputer/console#2574 * [e116e404](oxidecomputer/console@e116e404) bump web console to latest dogfood version * [67033a32](oxidecomputer/console@67033a32) oxidecomputer/console#2566 * [c4258804](oxidecomputer/console@c4258804) oxidecomputer/console#2568 * [0f922b2e](oxidecomputer/console@0f922b2e) cleanup: move getUseApiQueries down in the file to reduce diff noise elsewhere * [cf7802a7](oxidecomputer/console@cf7802a7) oxidecomputer/console#2565
Based on oxidecomputer/omicron#6774. Wait for that to merge so we can point at omicron main.