Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow handlers to return user-defined error types #1180

Merged
merged 61 commits into from
Dec 4, 2024
Merged

Allow handlers to return user-defined error types #1180

merged 61 commits into from
Dec 4, 2024

Commits on Nov 13, 2024

  1. [WIP] custom error responses using HttpResponse

    @hawkw
    hawkw committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    af226ea View commit details
    Browse the repository at this point in the history

  2. use a new trait, but HttpResponseContent

    @hawkw
    hawkw committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4d7c3e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. hmmm maybe this is good actually

    @hawkw
    hawkw committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5bd7e3d View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. wip schema generation

    @hawkw
    hawkw committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2eff88a View commit details
    Browse the repository at this point in the history

  2. use schemars existing deduplication

    @hawkw
    hawkw committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    f2c7f5f View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. use a refined type for error status 

    Enforce that `HttpResponseError`s status codes are 4xx or 5xx using an
`ErrorStatusCode` type which may only be those statuses. See: #39 (comment)

While we're making breaking API changes, let's also have
`HttpError::for_status` take a validated client-error-only type, rather
than panicking surprisingly. This way, it's obvious to the user that
the argument to this has to be a 4xx.

Fixes #693
    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8da1c05 View commit details
    Browse the repository at this point in the history

  2. just have HttpError be a normal HttpResponseError

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    86b3afb View commit details
    Browse the repository at this point in the history

  3. just rely on schemars to disambiguate colliding names

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1f611bf View commit details
    Browse the repository at this point in the history

  4. start documenting stuff

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    90e7247 View commit details
    Browse the repository at this point in the history

  5. TRYBUILD=overwrite

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    06a1af3 View commit details
    Browse the repository at this point in the history

  6. docs etc

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6de6de3 View commit details
    Browse the repository at this point in the history

  7. remove unneeded JsonSchema impl for HttpError

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cc4a2b9 View commit details
    Browse the repository at this point in the history

  8. theory of operation comment in error module

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c513c46 View commit details
    Browse the repository at this point in the history

  9. actually, we can completely insulate the user from HandlerError

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cfc582b View commit details
    Browse the repository at this point in the history

  10. EXPECTORATE=overwrite

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3d0575c View commit details
    Browse the repository at this point in the history

  11. fix wsrong doctest

    @hawkw
    hawkw committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6b4b6d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Merge branch 'main' into eliza/custom-error-httpresponse-result

    @hawkw
    hawkw authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5f374b8 View commit details
    Browse the repository at this point in the history

  2. rustfmt (NEVER use the github web merge editor)

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    53ed323 View commit details
    Browse the repository at this point in the history

  3. update to track merged changes

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ab798a9 View commit details
    Browse the repository at this point in the history

  4. EXPECTORATE=overwrite

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e87ad82 View commit details
    Browse the repository at this point in the history

  5. Apply docs suggestions from @ahl 

    Co-authored-by: Adam Leventhal <[email protected]>
    @hawkw @ahl
    hawkw and ahl authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6c9c824 View commit details
    Browse the repository at this point in the history

  6. remove local envrc

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    10a4a99 View commit details
    Browse the repository at this point in the history

  7. update copyright dates

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b9f194c View commit details
    Browse the repository at this point in the history

  8. reticulating comments

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    576ba5f View commit details
    Browse the repository at this point in the history

  9. reticulating comments

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8a4d52f View commit details
    Browse the repository at this point in the history

  10. nicer error for missing HttpResponse impls

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f9642d1 View commit details
    Browse the repository at this point in the history

  11. fix trait-based stub API not knowing about error schemas

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    8f6d70e View commit details
    Browse the repository at this point in the history

  12. EXPECTORATE=overwrite

    @hawkw
    hawkw committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ccbbbe2 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. whoops i forgot to add changes to endpoint tests

    @hawkw
    hawkw committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    46b4df1 View commit details
    Browse the repository at this point in the history

  2. convert HttpErrors into endpoint's error type 

    See #1180 (comment)

This does mean we can no longer have infallible endpoint handlers, but I
never actually wanted that in the first place --- it's just a side
benefit.
    @hawkw
    hawkw committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    00bcea7 View commit details
    Browse the repository at this point in the history

  3. add a note about HttpError

    @hawkw
    hawkw committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a6c3472 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2024

  1. reticulating implementation comments

    @hawkw
    hawkw committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    4c93e2e View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. update docs, improve examples

    @hawkw
    hawkw committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a0e71bf View commit details
    Browse the repository at this point in the history

  2. fix missing request ID header with custom errors

    @hawkw
    hawkw committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9a15443 View commit details
    Browse the repository at this point in the history

  3. add tests and test utils for custom errors

    @hawkw
    hawkw committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9c8d898 View commit details
    Browse the repository at this point in the history

  4. remove unrelated change

    @hawkw
    hawkw committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    2b7cdea View commit details
    Browse the repository at this point in the history

  5. Update dropshot/src/handler.rs 

    Co-authored-by: Adam Leventhal <[email protected]>
    @hawkw @ahl
    hawkw and ahl authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a3ee555 View commit details
    Browse the repository at this point in the history

  6. just panic

    @hawkw
    hawkw committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9d99131 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Update error.rs 

    Co-authored-by: David Pacheco <[email protected]>
    @hawkw @davepacheco
    hawkw and davepacheco authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5239d17 View commit details
    Browse the repository at this point in the history

  2. Update error.rs 

    Co-authored-by: David Pacheco <[email protected]>
    @hawkw @davepacheco
    hawkw and davepacheco authored Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a3497ea View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. add test for trait-bassed custom error APIs

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ab1d903 View commit details
    Browse the repository at this point in the history

  2. add wrong error type test with trait-based API

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ea5c9ef View commit details
    Browse the repository at this point in the history

  3. don't have trait-based API errors claim HttpError is required

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5bf8aa2 View commit details
    Browse the repository at this point in the history

  4. various comment suggestions from @davepacheco

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f315724 View commit details
    Browse the repository at this point in the history

  5. use a macro to generate ClientTestContext methods

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ba5c5b3 View commit details
    Browse the repository at this point in the history

  6. rsutfmt

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    84bca39 View commit details
    Browse the repository at this point in the history

  7. rename HttpError::for_status to for_client_error_with_status

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b017d57 View commit details
    Browse the repository at this point in the history

  8. document why HandlerError isnt publicly exported

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    72d0ced View commit details
    Browse the repository at this point in the history

  9. rm spurious comma

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6ad3bb4 View commit details
    Browse the repository at this point in the history

  10. fix typo

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d189d61 View commit details
    Browse the repository at this point in the history

  11. move ErrorStatusCode to its own module

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    71dc879 View commit details
    Browse the repository at this point in the history

  12. improve ErrorStatusCode docs

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    cab73b6 View commit details
    Browse the repository at this point in the history

  13. rustfmt again (oops)

    @hawkw
    hawkw committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c86d368 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. reuse response schemas as well as body schemas

    @hawkw
    hawkw committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    de6933c View commit details
    Browse the repository at this point in the history

  2. use schema name instead of type name when available

    @hawkw
    hawkw committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    c6f533d View commit details
    Browse the repository at this point in the history

  3. don't emit error schema for responses w/o status

    @hawkw
    hawkw committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6a0e990 View commit details
    Browse the repository at this point in the history

  4. fix accidental use of type name instead of name

    @hawkw
    hawkw committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    f0e6a46 View commit details
    Browse the repository at this point in the history

  5. add changelog entries

    @hawkw
    hawkw committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    6d6bff3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into eliza/custom-error-httpresponse-result

    @hawkw
    hawkw authored Dec 3, 2024
    Configuration menu
    Copy the full SHA
    8b648f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. oops i raced with the 0.14.0 release

    @hawkw
    hawkw committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    75cbc09 View commit details
    Browse the repository at this point in the history

  2. ugh what

    @hawkw
    hawkw committed Dec 4, 2024
    Configuration menu
    Copy the full SHA
    ba0f62a View commit details
    Browse the repository at this point in the history